-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Irregularity in the design #310
base: documentation_revamp
Are you sure you want to change the base?
Fixed Irregularity in the design #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @tachyons please merge
@@ -122,7 +122,7 @@ | |||
|
|||
<script src="//unpkg.com/[email protected]/lib/docsify.min.js"></script> | |||
<script src="//unpkg.com/docsify/lib/plugins/search.min.js"></script> | |||
<script src="//unpkg.com/docsify-pagination/dist/docsify-pagination.min.js"></script> | |||
<script src="js/docsify-pagination.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You made changes to this file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since I can not make changes to this file directly ,thats why I add the file in the js folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be editing libraries, override instead
Fixes #219
Changes done:
Screenshots:
Before -
After -
Preview Link(s):
✅️ By submitting this PR, I have verified the following