Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Irregularity in the design #310

Open
wants to merge 5 commits into
base: documentation_revamp
Choose a base branch
from

Conversation

Kartikay304
Copy link
Member

Fixes #219

Changes done:

  • Changed opacity of pagination-item to 1
  • Removed opacity hover effect on pagination-item

Screenshots:

Before -
before (1)

After -
after (1)

Preview Link(s):

  1. https://github.com/Kartikay304/CircuitVerseDocs/blob/6b805fe5fd97bffb38a28930e2acc32480571d6c/docs/js/docsifypagination.min.js
  2. https://github.com/Kartikay304/CircuitVerseDocs/blob/6b805fe5fd97bffb38a28930e2acc32480571d6c/docs/index.html

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add a link from the checks tab after checks complete)
  • Tried Squashing the commits into one

Copy link
Member

@nitin10s nitin10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tachyons please merge

@@ -122,7 +122,7 @@

<script src="//unpkg.com/[email protected]/lib/docsify.min.js"></script>
<script src="//unpkg.com/docsify/lib/plugins/search.min.js"></script>
<script src="//unpkg.com/docsify-pagination/dist/docsify-pagination.min.js"></script>
<script src="js/docsify-pagination.min.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made changes to this file ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since I can not make changes to this file directly ,thats why I add the file in the js folder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be editing libraries, override instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irregularity in the design
3 participants