Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_changes] Adding new module for IGMP Snooping policy (DCNE-130) #568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[minor_changes] Adding new module for IGMP Snooping policy (DCNE-130) #568

wants to merge 1 commit into from

Conversation

anvitha-jain
Copy link
Collaborator

@anvitha-jain anvitha-jain commented Nov 13, 2024 •
edited
Loading

IGMP Snooping policy in Tenant Policy Templates. It is part of schema_template_bd module.
solves #455

@anvitha-jain anvitha-jain self-assigned this Nov 13, 2024
@anvitha-jain anvitha-jain linked an issue Nov 13, 2024 that may be closed by this pull request
Enhancement: New module for IGMP Snooping Policy in Tenant Tenant Policies Template (DCNE-130) #455
Open
@github-actions github-actions bot changed the title [minor_changes] Adding new module for IGMP Snooping policy [minor_changes] Adding new module for IGMP Snooping policy (DCNE-130) Nov 13, 2024
akinross
akinross previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we might need to rebase and use function from this: #569

gmicol
gmicol previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvitha-jain anvitha-jain dismissed stale reviews from shrsr, gmicol, and akinross via 65785e3 December 12, 2024 07:35
gmicol
gmicol requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify your module using the new append_update_ops_data function? for references, look at the recent ansible-mso PRs that are in review in 'progress' or 'ready to merge'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol requested changes

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

@samiib samiib Awaiting requested review from samiib samiib is a code owner

@akinross akinross Awaiting requested review from akinross akinross is a code owner

@shrsr shrsr Awaiting requested review from shrsr shrsr is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@anvitha-jain anvitha-jain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for IGMP Snooping Policy in Tenant Tenant Policies Template (DCNE-130)
5 participants
@anvitha-jain @shrsr @akinross @samiib @gmicol