Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft conductor 23sept2022 1 #121

Open
wants to merge 371 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
371 commits
Select commit Hold shift + click to select a range
91adde7
Merge pull request #2872 from Netflix/taskmapper_refactoring
aravindanr Mar 30, 2022
d09f341
Merge remote-tracking branch 'origin/main'
aravindanr Mar 30, 2022
cec0006
Event handler for loop over task. (#2883)
manan164 Mar 30, 2022
c9d7f50
fixed broken links
aravindanr Mar 30, 2022
38a9fc7
Miscellaneous documentation fixes
aravindanr Mar 30, 2022
94f0c32
Update Gradle Wrapper from 7.4 to 7.4.2.
gradle-update-robot Apr 1, 2022
100226f
chore: Disable ES in local docker config
NickTomlin Apr 4, 2022
c64bdd0
integ test for dynamic fork with subworkflow external storage
apanicker-nflx Dec 18, 2021
33c47a1
Merge pull request #2657 from Netflix/dynamic_fork_swf_external_storage
apanicker-nflx Apr 5, 2022
223f729
Workflow as Code SDK for Conductor (#2856)
v1r3n Apr 6, 2022
779edb4
Bump protobuf-java from 3.19.4 to 3.20.0
dependabot[bot] Apr 6, 2022
ee4c7e4
Fix credentials for es6 (#2900)
shofstee Apr 6, 2022
2a68ef1
Merge pull request #2895 from NickTomlin/ntomlin/docker
apanicker-nflx Apr 7, 2022
6f180f5
Bump cglib from 3.2.4 to 3.3.0
dependabot[bot] Apr 7, 2022
be80879
Merge pull request #2891 from Netflix/gradlew-update-7.4.2
apanicker-nflx Apr 7, 2022
fe65ced
Merge pull request #2901 from Netflix/dependabot/gradle/cglib-cglib-3…
apanicker-nflx Apr 7, 2022
dd831bf
Merge pull request #2902 from Netflix/dependabot/gradle/com.google.pr…
apanicker-nflx Apr 7, 2022
c7ab4fd
updated dependencies
apanicker-nflx Apr 7, 2022
175ca6d
ignore codes raised by new spotbugs
apanicker-nflx Apr 7, 2022
b65fc50
Merge pull request #2905 from Netflix/spotbugs_fix
apanicker-nflx Apr 7, 2022
271e7e7
Bump moment from 2.29.1 to 2.29.2 in /ui
dependabot[bot] Apr 9, 2022
ad2beae
Merge remote-tracking branch 'origin/main'
aravindanr Apr 11, 2022
e38d917
Cleanup styles. Fix scrolling in task sidebar. Issue #2877
peterlau Apr 11, 2022
4b5317f
Workflow Workbench
peterlau Apr 11, 2022
a5034eb
Fix validation error handling in workflow editor
peterlau Apr 11, 2022
b4cbbed
Merge remote-tracking branch 'origin/main'
aravindanr Apr 13, 2022
48a8e9d
[UI] Fix bulk retry button
peterlau Apr 13, 2022
f93a9b0
SQL to SQS eventing name
torgge Apr 13, 2022
d045c14
added dedicated methods to serialize/deserialize input/output data
aravindanr Apr 13, 2022
9f55424
Merge branch 'main' of github.com:Netflix/conductor
aravindanr Apr 14, 2022
f48dbb8
Set permissions for GitHub actions
nathannaveen Apr 15, 2022
ffc1454
#2913 fixed dead links
aravindanr Apr 18, 2022
234e16a
Bump actions/upload-artifact from 2 to 3
dependabot[bot] Apr 11, 2022
7d59be2
Bump actions/setup-java from 2 to 3
dependabot[bot] Apr 11, 2022
d8dfb8f
Merge pull request #2922 from turrisxyz/naveen/feat/set-perms-actions
apanicker-nflx Apr 18, 2022
4ad982a
Merge pull request #2920 from torgge/patch-1
apanicker-nflx Apr 18, 2022
a40c297
SB 2.6.6 changes
aravindanr Apr 19, 2022
b0925ac
1. added explicit dependency for junit
aravindanr Apr 19, 2022
8d5eee3
#2926 added a null check for TaskModel
aravindanr Apr 19, 2022
5b54ba6
fix update gradle wrapper workflow
apanicker-nflx Apr 21, 2022
b67b139
Bump protobuf-java from 3.20.0 to 3.20.1
dependabot[bot] Apr 25, 2022
ebc43ad
Bump com.gradle.enterprise from 3.9 to 3.10
dependabot[bot] Apr 25, 2022
3a03815
Allow Overrding of IDGenerator (#2910)
v1r3n Apr 25, 2022
26421e2
Merge pull request #2946 from Netflix/dependabot/gradle/com.google.pr…
apanicker-nflx Apr 26, 2022
f3bf576
Merge pull request #2947 from Netflix/dependabot/gradle/com.gradle.en…
apanicker-nflx Apr 26, 2022
e739c34
remove guava from common module;handle exceptions in sweeper
apanicker-nflx Apr 15, 2022
5742b13
Merge pull request #2923 from Netflix/remove_guava
apanicker-nflx Apr 26, 2022
78097a4
Merge branch 'main' of github.com:Netflix/conductor
aravindanr Apr 27, 2022
32fb49b
Remove misnamed/unused files. Update yarn.lock
peterlau Apr 27, 2022
e66c73d
Corrected the tokenization logic. The INDEX_DELIMITER could be part o…
aravindanr Apr 27, 2022
1bff606
Merge branch 'main' of github.com:Netflix/conductor
aravindanr Apr 27, 2022
aca47e4
Updated related.md to add conductor sdks (#2952)
CherishSantoshi Apr 28, 2022
a13706f
Add an ack request for each task polled from queue, when polling in b…
gardusig Apr 28, 2022
ffee4cb
Merge branch 'main' of github.com:Netflix/conductor
aravindanr Apr 28, 2022
51a906f
spotless format
aravindanr Apr 28, 2022
bc68c9c
move contributed modules into community repo
apanicker-nflx Feb 15, 2022
a32128b
Merge pull request #2774 from Netflix/move_modules
apanicker-nflx Apr 29, 2022
473ed87
reference community repo from readme
apanicker-nflx May 2, 2022
309afc6
Merge pull request #2954 from gardusig/ack-task-poll-batch
apanicker-nflx May 2, 2022
009ffed
fixed typos
amolkatdare May 3, 2022
2dd89d1
Merge branch 'main' of github.com:Netflix/conductor
aravindanr May 3, 2022
544ed14
Merge pull request #2962 from amolkatdare/patch-1
apanicker-nflx May 3, 2022
7f8a6b0
remove manual acking in tests, since this done by default
apanicker-nflx May 3, 2022
4e1f08a
Fix for NPE when header values are null (#2964)
muralicmr May 4, 2022
a0cc539
Update documentation for loop task (DO_WHILE) (#2965)
manan164 May 4, 2022
3efbb83
Redis password authentication support (#2950)
jmigueprieto May 4, 2022
127fc32
Add visual Loop representation. (#2963)
pablocubico May 5, 2022
9bb8db8
only allow rerun on terminal workflows
apanicker-nflx May 5, 2022
813bb71
Merge pull request #2973 from Netflix/rerun_check
apanicker-nflx May 6, 2022
9c26ed6
fixed links and spelling in java SDK docs (#2915)
dougsillars May 9, 2022
aed35ee
Merge branch 'main' of github.com:Netflix/conductor
aravindanr May 9, 2022
13df874
removed submodule
aravindanr May 9, 2022
2b7fc9e
New api to query queue size based on task type, domain and other opti…
aravindanr May 5, 2022
67f39ba
deprecated /queue/sizes endpoint
aravindanr May 9, 2022
f5bc54f
Delete question.md (#2980)
jxu-nflx May 10, 2022
8b1c50f
Fix update with large payload task result (#2982)
apanicker-nflx May 10, 2022
2dc6d6a
[UI] Control react-query key array explication in useFetch. Fixes #2977.
peterlau May 12, 2022
0c972ef
[UI] Upgrade react-scripts to 5.0.0. Also upgrade devDependencies and…
peterlau May 12, 2022
9190e11
Fix for #1677, inspired from #2881. Loop-over tasks are created in th…
aravindanr May 5, 2022
e6128e3
MockExternalPayloadStorage that uses different files for different pa…
aravindanr May 16, 2022
bc9df66
added an additional assertion in cassandra event execution test
apanicker-nflx May 16, 2022
d0add13
merge main
aravindanr May 16, 2022
4f6afcf
add dependencies for jersey to support springboot version upgrade
aravindanr May 16, 2022
c43ade9
Merge pull request #2934 from Netflix/sb_2.6.6
aravindanr May 16, 2022
028a082
Optional subworkflow task (#2974)
jxu-nflx May 17, 2022
4fc986d
Documentation Site Update (#2989)
peterlau May 17, 2022
b78ce49
Update logo in README and Swagger UI (#2990)
peterlau May 17, 2022
456f52f
Docsite typos
peterlau May 17, 2022
e7c19b2
Add Google Search Console validation to docsite
peterlau May 17, 2022
cb7ad07
Fix docsite description (for SEO)
peterlau May 17, 2022
6d4db1a
Bump spring-boot-gradle-plugin from 2.3.12.RELEASE to 2.6.7
dependabot[bot] May 17, 2022
a08510d
dependecy lock update for SB 2.6.7
aravindanr May 17, 2022
0276192
Merge branch 'main' into docsite
peterlau May 20, 2022
92c82e3
introducing NotFoundException
aravindanr May 22, 2022
8ec7cf3
introducing ConflictException
aravindanr May 22, 2022
6933076
Bump com.gradle.enterprise from 3.10 to 3.10.1
dependabot[bot] May 23, 2022
02cfb1c
Merge pull request #3002 from Netflix/dependabot/gradle/com.gradle.en…
apanicker-nflx May 23, 2022
144a4de
Log workflow failures (#3004)
skorse May 24, 2022
e581b14
Add Supercharge
martonbtoth May 25, 2022
36a62d2
Human Task (#2987)
v1r3n May 31, 2022
3b5aed1
Enhance WAIT task to support time-based wait scenarios (#2986)
v1r3n May 31, 2022
2f0a308
Create adhoc taskdef if not exist (#3005)
jxu-nflx May 31, 2022
90b8d8f
Bump protobuf-java from 3.20.1 to 3.21.1 (#3014)
dependabot[bot] May 31, 2022
deb0306
Update pull_request_template.md (#3018)
jxu-nflx May 31, 2022
beb776d
Update pull_request_template.md
jxu-nflx Jun 1, 2022
81b81c3
Update pull_request_template.md
jxu-nflx Jun 1, 2022
f81978c
Update pull_request_template.md
jxu-nflx Jun 1, 2022
7b90c64
Fix: Enable extra task fields in Java-SDK (#3009)
lj-ovo Jun 1, 2022
f82caba
Introducing RequestHandler which encapsulates all HTTP operations. Th…
aravindanr Jun 2, 2022
aae94ac
removed usages of Guava
aravindanr Jun 3, 2022
73284fc
Typo fix (#3029)
AFelkai Jun 5, 2022
5c906f3
Merge branch 'main' of github.com:Netflix/conductor into client_reque…
aravindanr Jun 6, 2022
e0047c8
Merge pull request #3024 from Netflix/client_requesthandler
aravindanr Jun 6, 2022
9b06567
task summary ui (#3028)
jxu-nflx Jun 6, 2022
7889c30
introducing NotFoundException
aravindanr May 22, 2022
39bee23
introducing ConflictException
aravindanr May 22, 2022
d11c7b8
additional constructors in JerseyRequestHandler to simplify its creation
aravindanr Jun 10, 2022
a02df89
updated reminder about formatting
aravindanr Jun 10, 2022
f347aa2
Merge branch 'exception_refactoring' of github.com:Netflix/conductor …
aravindanr Jun 10, 2022
6707051
Merge branch 'main' into exception_refactoring
aravindanr Jun 10, 2022
c483cc4
INVALID_INPUT to IllegalArgumentException
aravindanr Jun 10, 2022
b4a8167
BACKEND_ERROR to TransientException
aravindanr Jun 10, 2022
4ee3eaf
Replace old logo asset with new logo
peterlau Jun 8, 2022
c64be40
Raise max results per page to 1000
peterlau Jun 8, 2022
03d3b5c
[UI] Separate workflowDefs from latestWorkflowDefs. Reuse existing re…
peterlau Jun 8, 2022
3dc9028
[UI] Refactor task related data hooks.
peterlau Jun 8, 2022
4ae011d
[UI] Support terminate with reason in Actions & Bulk Actions
peterlau Jun 8, 2022
276e20d
[UI] Search for Tasks directly
peterlau Jun 8, 2022
f968bf3
[UI] Refactor Task Poll Data page to correctly account for domains.
peterlau Jun 8, 2022
46c2baf
[UI] Fix duration formatting
peterlau Jun 8, 2022
0dde3a1
[UI] Update views to use refactored workflow data hooks and Dropdowns
peterlau Jun 8, 2022
ced5343
[UI] Refactor Do-while loops
peterlau Jun 8, 2022
d013dcd
[UI] Use new logo in AppLogo
peterlau Jun 8, 2022
1a1fe74
sdk documentation additions (#3047)
dougsillars Jun 15, 2022
97a0393
Merge branch 'main' into docsite
peterlau Jun 16, 2022
a99e939
Bugfix/jointask output (#3055)
jxu-nflx Jun 22, 2022
8674c91
INTERNAL_ERROR to NonTransientException
aravindanr Jun 22, 2022
83841ac
handle 204 during GET
aravindanr Jun 27, 2022
caad53d
corrected JerseyRequestHandler initialization in ClientBase
aravindanr Jun 27, 2022
c751761
DoWhileTaskMapper computes and stores input
aravindanr Jun 29, 2022
27af660
DoWhile checks if all tasks in an iteration are terminal before movin…
aravindanr Jun 29, 2022
a866469
DoWhile test with only system tasks inside
aravindanr Jun 30, 2022
edf9689
added checks for HTTP status in put and post methods
aravindanr Jun 30, 2022
eba6185
updated Jedis version for redis-concurrency-limit module
aravindanr Jun 30, 2022
8bc6e18
added missing runtime dependencies for the Jersey client.
aravindanr Jun 30, 2022
6c496a6
miscellaneous fixes for broken tests
aravindanr Jun 30, 2022
cff6aac
Ignored test since it always fails in CI
aravindanr Jun 30, 2022
fe135aa
added junit-vintage-engine and dependency updates
aravindanr Jun 30, 2022
f97b0cb
GitHub actions to publish test results
aravindanr Jun 30, 2022
c07b79f
Improve message for payload size threshold (#3075)
flavioschuindt Jun 30, 2022
3079f02
Bump io.spring.dependency-management (#3077)
dependabot[bot] Jul 1, 2022
b7ea1cc
Update WHOISUSING.md (#3078)
flavioschuindt Jul 1, 2022
29afa92
Removed ApplicationException
aravindanr Jul 2, 2022
ee02a86
Merge branch 'main' of github.com:Netflix/conductor into exception_re…
aravindanr Jul 2, 2022
0d6430d
Cap retryCount limit to 10 (#3079)
skorse Jul 5, 2022
ddc1bed
Added metrics for ExecutionLockService, DeciderService and WorkflowEx…
aravindanr Jul 5, 2022
9e1364b
changed RetryTemplate logic for finding TransientException
aravindanr Jul 2, 2022
35fea12
Merge pull request #3003 from Netflix/exception_refactoring
aravindanr Jul 7, 2022
9af99ca
added null check for input/output data before adding to the map
aravindanr Jul 8, 2022
ec35fff
cache in CassandraMetadataDAO and CassandraEventHandlerDAO are added …
aravindanr Jul 8, 2022
4a23fb2
removed references of ApplicationException
aravindanr Jul 8, 2022
90a89f6
used eventHandlerCache where possible
aravindanr Jul 8, 2022
7882c61
metric includes task def name
aravindanr Jul 8, 2022
036c0b2
Set size limit for task exec log and add metrics (#3096)
jxu-nflx Jul 8, 2022
16fa902
API endpoint for workflow names and versions (#3099)
peterlau Jul 12, 2022
c2a5ef1
Show linenumbers in JSON viewer
peterlau Jul 12, 2022
1c50920
Update Task selection handling and DO_WHILE viz
peterlau Jul 12, 2022
072ba24
Cypress UI testing in OSS
peterlau Jul 12, 2022
e75ad33
[UI] show ms in timestamps
peterlau Jul 13, 2022
b2dd75d
run cypress tests in github ci
peterlau Jul 13, 2022
236830e
Fix typo: persistance → persistence (#3111)
gaffney Jul 18, 2022
0388b12
Bump protobuf-gradle-plugin from 0.8.18 to 0.8.19 (#3080)
dependabot[bot] Jul 19, 2022
ed638cd
For INLINE task, corrected reasonForIncompletion field to include the…
aravindanr Jul 18, 2022
e841f73
API to validate a workflow definition
aravindanr Jul 14, 2022
2c16fa8
Create SECURITY.md
aravindanr Jul 19, 2022
a7c30b1
during updateTask only the workflow is loaded, not all the tasks inside
aravindanr Jul 20, 2022
c1dca57
Update README.md (#3123)
andyczerwonka Jul 25, 2022
1a105c9
Bump protobuf-java from 3.21.1 to 3.21.3 (#3128)
dependabot[bot] Jul 25, 2022
f171f62
Bump spring-boot-gradle-plugin from 2.6.7 to 2.7.2 (#3129)
dependabot[bot] Jul 25, 2022
6c94cae
Adjust maven repostiory URL for grpc. (#3134)
matteius Aug 1, 2022
4870585
added human task, updates to terminate and dowhile (#3049)
dougsillars Aug 1, 2022
b88ad1d
Parameterized support for duration and until in wait task. (#3058)
manan164 Aug 1, 2022
cae0d88
Bump org.sonarqube from 3.3 to 3.4.0.2513 (#3045)
dependabot[bot] Aug 1, 2022
aa02a44
Bump com.gradle.enterprise from 3.10.1 to 3.10.3 (#3100)
dependabot[bot] Aug 1, 2022
dcd29ae
Bump com.google.protobuf from 0.8.18 to 0.8.19 (#3117)
dependabot[bot] Aug 1, 2022
e93c3ae
Bump protobuf-java from 3.21.3 to 3.21.4 (#3140)
dependabot[bot] Aug 1, 2022
a88f133
Fix: connect cases to loop end. Ignore cases in execution.
pablocubico Aug 3, 2022
8459632
Bump terser from 5.14.1 to 5.14.2 in /ui
dependabot[bot] Aug 5, 2022
0b85b70
do not synchronously eval workflow during update task for select crit…
apanicker-nflx Aug 5, 2022
b0b05da
Jxu/springcache (#3143)
jxu-nflx Aug 5, 2022
ab14727
Jxu/cassandra serde (#3144)
jxu-nflx Aug 5, 2022
d7dd2e9
add `removeWorkflowWithExpiry` back to ExecutionDAOFacade (#3150)
jxu-nflx Aug 5, 2022
8cdb439
Add cosmetic edge to left of loop. Adjust bar size.
pablocubico Aug 8, 2022
55d083d
Add a bit of margin.
pablocubico Aug 8, 2022
440d1f3
eclipse temurin replacing openjdk base images (#3142)
amimimor Aug 8, 2022
13aed8e
Update Gradle Wrapper from 7.4.2 to 7.5.1. (#3151)
github-actions[bot] Aug 8, 2022
27fca2d
Fix property name in ReadMe
apanicker-nflx Aug 8, 2022
e20a193
Fix a subworkflow performance issue without selecting tasks (#3152)
james-deee Aug 9, 2022
88d1b44
Read subworkflowId from task object directly
peterlau Aug 9, 2022
c526c65
remove obsolete TODOs and refactor (#3161)
apanicker-nflx Aug 10, 2022
15efeaa
refresh task definitions when latest is requested during restart
apanicker-nflx Aug 10, 2022
6d51468
Merge branch 'main' into fix-switch-loop
peterlau Aug 11, 2022
e0c37de
[UI] - Some changes to PR # 3158
peterlau Aug 11, 2022
1422337
Merge branch 'main' of github.com:Netflix/conductor into fix-switch-loop
peterlau Aug 11, 2022
5661251
Merge pull request #3174 from Netflix/fix-switch-loop
peterlau Aug 11, 2022
edc5781
[UI] Fix edge case where tasks have refs that resemble those inside o…
peterlau Aug 11, 2022
af4be6a
[UI] Add definition link from execution view
peterlau Aug 11, 2022
2d51469
Performance improvements in Decider (#3070)
v1r3n Aug 14, 2022
ba3c5b9
revert to c89e78081d6ff7e80740be35fb2a11e69a1b7a47 (#3172)
jxu-nflx Aug 15, 2022
478ea92
Updated tasklifecycle.md - mis-spelled word (#3173)
ropereraLK Aug 15, 2022
9cb3bbc
repair inconsistent subworkflow task (#3183)
apanicker-nflx Aug 16, 2022
c1695c3
Bump io.spring.dependency-management (#3177)
dependabot[bot] Aug 16, 2022
8b23803
Bump com.gradle.enterprise from 3.10.3 to 3.11.1 (#3178)
dependabot[bot] Aug 16, 2022
52ba7ce
Bump protobuf-java from 3.21.4 to 3.21.5 (#3179)
dependabot[bot] Aug 16, 2022
8b62e35
Split event system task implementation between start and execute (#3187)
apanicker-nflx Aug 18, 2022
33062f3
Failed task names (#3185)
peterlau Aug 18, 2022
c66b36d
add task domain to the index (#3188)
apanicker-nflx Aug 19, 2022
6f8daab
task lease extend (#3186)
jxu-nflx Aug 19, 2022
5d9734e
Extract map body from json_jq output (#3190)
jxu-nflx Aug 19, 2022
bd85544
updated polyglot-client directory (#3074)
dougsillars Aug 22, 2022
b61cab5
Bump spring-boot-gradle-plugin from 2.7.2 to 2.7.3 (#3193)
dependabot[bot] Aug 22, 2022
6b8e920
Add click event on Workflow definition to determine the position in t…
Jun 23, 2022
630b870
Fix next task not scheduled after switch completes (#3197)
jxu-nflx Aug 24, 2022
db841ac
[Docs] Fixed Language issues. (#3200)
ropereraLK Aug 25, 2022
7528e80
[docs] Add Hosted Solutions section
peterlau Sep 1, 2022
b17ede7
during start, decide is performed inside a lock
aravindanr Sep 1, 2022
f6dbe62
during skipTaskFromWorkflow, decide is performed inside a lock
aravindanr Sep 1, 2022
037b8a6
Extract json node body from json_jq task output (#3207)
jxu-nflx Sep 2, 2022
6413a12
Combined input/output data if additional payload is added when update…
jxu-nflx Sep 2, 2022
a2a64e6
do not stringify null results in json jq task (#3225)
apanicker-nflx Sep 8, 2022
b843af4
fix subworkflow output during repair (#3232)
apanicker-nflx Sep 10, 2022
312160b
fix missing update time because of different field names in WorkflowM…
c4lm Sep 12, 2022
25b234c
removed usages of TaskModel#getOutputData().put()
aravindanr Sep 10, 2022
b0c1b89
Adding parameterUtils in do-while task to compute input at each itera…
manan164 Sep 19, 2022
ae06fce
Bump protobuf-java from 3.21.5 to 3.21.6 (#3247)
dependabot[bot] Sep 19, 2022
1040eaf
Update docker.md (#3253)
IonutGrosu Sep 21, 2022
7b0e601
ISICO-13908: Merge changes from netflix main
fthankac Sep 28, 2022
ed2051f
ISICO-13908: es7 folder
fthankac Sep 29, 2022
b7827b6
ISICO-13908: adding contribs module
fthankac Oct 7, 2022
5c91cb2
ISICO-13908: fixing es7 module compliations
fthankac Oct 7, 2022
c4ae2e4
ISICO-13908: fixing es7 module compliations
fthankac Oct 7, 2022
0280db7
ISICO-13908: fixing UT
fthankac Oct 11, 2022
0c5b49f
ISICO-13908: fixing conflict in classpath related to jar
fthankac Oct 17, 2022
4acd41d
ISICO-13908: Resolve conflicts from master
fthankac Oct 18, 2022
3464e96
ISICO-13908: Addressing UT failures
fthankac Oct 18, 2022
a3fca78
ISICO-13908: Fix task retry count
fthankac Nov 10, 2022
61462eb
ISICO-13908: Conflict resolve from master
fthankac Nov 14, 2022
7844d1d
ISICO-13908: addressing review comments
fthankac Dec 6, 2022
cbd9dae
ISICO-13908: addressing review comments and pulling latest code from …
fthankac Dec 9, 2022
ddf3a55
ISICO-13908: addressing review comments from confluence link https://…
fthankac Dec 13, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 0 additions & 10 deletions .github/ISSUE_TEMPLATE/question.md

This file was deleted.

3 changes: 2 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
Pull Request type
----

- [ ] Bugfix
- [ ] Feature
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes (Please run `./gradlew generateLock saveLock` to refresh dependencies)
- [ ] WHOSUSING.md
- [ ] Other (please describe):

**NOTE**: Please remember to run `./gradlew spotlessApply` to fix any format violations.

Changes in this PR
----

Expand Down
2 changes: 2 additions & 0 deletions .github/release-drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,5 @@ version-resolver:

exclude-labels:
- 'skip-changelog'
- 'gradle-wrapper'
- 'github_actions'
50 changes: 1 addition & 49 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -1,49 +1 @@
# Contributor Covenant Code of Conduct

## Our Pledge

In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, sex characteristics, gender identity and expression, level of experience education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.

Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at [email protected]. All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html

[homepage]: https://www.contributor-covenant.org

For answers to common questions about this code of conduct, see
https://www.contributor-covenant.org/faq
[Code of Conduct](docs/docs/resources/code-of-conduct.md)
73 changes: 1 addition & 72 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,72 +1 @@
Thanks for your interest in Conductor!
This guide helps to find the most efficient way to contribute, ask questions, and report issues.

Code of conduct
-----

Please review our [code of conduct](CODE_OF_CONDUCT.md).

I have a question!
-----

We have a dedicated [discussion forum](https://github.com/Netflix/conductor/discussions) for asking "how to" questions and to discuss ideas. The discussion forum is a great place to start if you're considering creating a feature request or work on a Pull Request.
*Please do not create issues to ask questions.*

I want to contribute!
------

We welcome Pull Requests and already had many outstanding community contributions!
Creating and reviewing Pull Requests take considerable time. This section helps you set up for a smooth Pull Request experience.

The stable branch is [main](https://github.com/Netflix/conductor/tree/main).

Please create pull requests for your contributions against [main](https://github.com/Netflix/conductor/tree/main) only.

It's a great idea to discuss the new feature you're considering on the [discussion forum](https://github.com/Netflix/conductor/discussions) before writing any code. There are often different ways you can implement a feature. Getting some discussion about different options helps shape the best solution. When starting directly with a Pull Request, there is the risk of having to make considerable changes. Sometimes that is the best approach, though! Showing an idea with code can be very helpful; be aware that it might be throw-away work. Some of our best Pull Requests came out of multiple competing implementations, which helped shape it to perfection.

Also, consider that not every feature is a good fit for Conductor. A few things to consider are:

* Is it increasing complexity for the user, or might it be confusing?
* Does it, in any way, break backward compatibility (this is seldom acceptable)
* Does it require new dependencies (this is rarely acceptable for core modules)
* Should the feature be opt-in or enabled by default. For integration with a new Queuing recipe or persistence module, a separate module which can be optionally enabled is the right choice.
* Should the feature be implemented in the main Conductor repository, or would it be better to set up a separate repository? Especially for integration with other systems, a separate repository is often the right choice because the life-cycle of it will be different.

Of course, for more minor bug fixes and improvements, the process can be more light-weight.

We'll try to be responsive to Pull Requests. Do keep in mind that because of the inherently distributed nature of open source projects, responses to a PR might take some time because of time zones, weekends, and other things we may be working on.

I want to report an issue
-----

If you found a bug, it is much appreciated if you create an issue. Please include clear instructions on how to reproduce the issue, or even better, include a test case on a branch. Make sure to come up with a descriptive title for the issue because this helps while organizing issues.

I have a great idea for a new feature
----
Many features in Conductor have come from ideas from the community. If you think something is missing or certain use cases could be supported better, let us know! You can do so by opening a discussion on the [discussion forum](https://github.com/Netflix/conductor/discussions). Provide as much relevant context to why and when the feature would be helpful. Providing context is especially important for "Support XYZ" issues since we might not be familiar with what "XYZ" is and why it's useful. If you have an idea of how to implement the feature, include that as well.

Once we have decided on a direction, it's time to summarize the idea by creating a new issue.

## Code Style
We use [spotless](https://github.com/diffplug/spotless) to enforce consistent code style for the project, so make sure to run `gradlew spotlessApply` to fix any violations after code changes.

## License

By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/Netflix/conductor/blob/master/LICENSE

All files are released with the Apache 2.0 license, and the following license header will be automatically added to your new file if none present:

```
/**
* Copyright $YEAR Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/
```
[Contributing](docs/docs/resources/contributing.md)
Loading