Captive portal #12
Merged
Captive portal #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Repeated testing on iOS didn't trigger the captive portal, but forgetting and reconnecting to the Noisemeter WiFi fixed it. We will probably just need to give users a note to forget the network if they happen to be re-configuring their device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of the work done in the
dnsbranch and the code from the esp32-captive-portal-example to implement captive portal functionality in the latest code. I adjusted the code to follow Arduino'sRequestHandlerinterface that I had ourAccessPointclass inherit, so we could avoid including the additional Async libraries that the example code used.The redirect on WiFi connection appears to be working: I've tested this on Windows/Firefox, Linux/Firefox, iOS/WebKit, and Android.