Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border-radius for bubble-media-player #1015

Conversation

MrBearPresident
Copy link
Collaborator

Fixes issue #747

@Clooos Clooos merged commit d381295 into Clooos:main Dec 12, 2024
2 checks passed
@Clooos
Copy link
Owner

Clooos commented Dec 12, 2024

Thank you! This is merged!

@MrBearPresident MrBearPresident deleted the 747-media-player-button-loses-rounded-corners-when-adding-a-fourth-rgba-value branch December 12, 2024 13:14
@gmalbert
Copy link

gmalbert commented Dec 12, 2024

I'm not seeing this as corrected, and for me, it's actually worse. Now all of the cards (other than section header) are rectangles rather than rounded, and I removed the rgba values completely to avoid this issue. Code is below. I'm not seeing heading titles now either. Same or different issue? I'm on the latest version: 2.3.2.

image

type: vertical-stack
cards:
  - type: custom:bubble-card
    card_type: pop-up
    hash: "#music"
    button_type: switch
    icon: mdi:music-box-multiple-outline
    name: Music Assistant
    tap_action:
      action: navigate
      navigation_path: /music-assistant
    double_tap_action:
      action: more-info
    hold_action:
      action: more-info
    button_action:
      tap_action:
        action: navigate
        navigation_path: /music-assistant
    show_attribute: false
  - type: custom:bubble-card
    card_type: media-player
    entity: media_player.bedroom
    show_state: false
    name: Bedroom
  - type: custom:bubble-card
    card_type: media-player
    entity: media_player.office_homepod
    show_state: false
    name: Office
  - type: custom:bubble-card
    card_type: media-player
    entity: media_player.basement_homepod
    show_state: false
    name: Basement
  - type: custom:bubble-card
    card_type: media-player
    entity: media_player.movie_room_homepod
    show_state: false
    name: Movie Room

@Clooos
Copy link
Owner

Clooos commented Dec 12, 2024

That's my fault! I'm made a mistake with the @MrBearPresident's PR! I will fix that really soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media player button loses rounded corners when adding a fourth rgba value
3 participants