Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG2ICO conversion #1271

Open
3 tasks done
holzerseb opened this issue Aug 27, 2024 · 5 comments · May be fixed by #1276
Open
3 tasks done

PNG2ICO conversion #1271

holzerseb opened this issue Aug 27, 2024 · 5 comments · May be fixed by #1276
Labels
enhancement New feature or request triage

Comments

@holzerseb
Copy link

What type of request is this?

New tool idea

Clear and concise description of the feature you are proposing

Thanks for the fantastic project! I love IT-Tools.
There is one feature I would love to see: PNG/JPG/TIFF to ICO, as well as ICO to PNG/JPG/TIFF Conversion. I regularly need to convert images to ico files for development purposes. Currently I need to manually do this in Gimp or through some online converter - but it would be fantastic if I could just use IT-Tools for that.
ICO conversion should be possible client side also.

Is their example of this tool in the wild?

https://convertio.co/png-ico/

Additional context

No response

Validations

  • Check the feature is not already implemented in the project.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Check that the feature can be implemented in a client side only app (IT-Tools is client side only, no server).
@holzerseb holzerseb added enhancement New feature or request triage labels Aug 27, 2024
sharevb added a commit to sharevb/it-tools that referenced this issue Sep 1, 2024
@sharevb sharevb linked a pull request Sep 1, 2024 that will close this issue
sharevb added a commit to sharevb/it-tools that referenced this issue Sep 1, 2024
@sharevb
Copy link
Contributor

sharevb commented Sep 1, 2024

Hi @holzerseb and @CorentinTh, implemented in PR #1276

@steffenrapp
Copy link
Contributor

Wouldn't it make sense to follow a more global approach like convert any image format to any other image format in one tool instead of limiting it to exactly these formats?

@sharevb
Copy link
Contributor

sharevb commented Sep 4, 2024

Hi @steffenrapp, this tool is a kind of "special conversion" since ICO contains more than one image resolution. But a tool that convert between image format could also be interesting

@holzerseb
Copy link
Author

Notification about this must have slipped by just found this as I needed the feature today again :smiling, thank you so much @sharevb for the implementation, I hope the PR can be merged in an upcoming update, thank you!

@sharevb
Copy link
Contributor

sharevb commented Dec 11, 2024

Hi, for people interested in up to date version of it-tools, I made kind of a fork here : https://github.com/sharevb/it-tools (https://sharevb-it-tools.vercel.app/ and docker images https://github.com/sharevb/it-tools/pkgs/container/it-tools)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants