Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new tool): ICO <> PNG Converter #1276

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Sep 1, 2024

Fix #1271

Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Dec 11, 2024 4:10pm

Copy link

sonarqubecloud bot commented Sep 1, 2024

@sharevb sharevb mentioned this pull request Sep 1, 2024
3 tasks
@sharevb sharevb marked this pull request as ready for review September 1, 2024 20:32
@steffenrapp
Copy link
Contributor

Hi @sharevb I did a basic test. PNG->ICO worked fine but when I converted that ICO->PNG it didn't take the "best" version from the .ico only the 2nd best. I think it should use the highest available resolution instead. Maybe you can check if you can reproduce that.

@sharevb
Copy link
Contributor Author

sharevb commented Sep 13, 2024

Hi @steffenrapp, I use an external library, probably need to create an issue with the given ico file in https://github.com/yegor-pelykh/image-in-browser

@holzerseb
Copy link

Thanks @sharevb for the PR, looks like since the PR and the current branch some changes resulted in conflicts. I'm really looking forward to having this feature in IT-Tools, as most online converters have a limit on how many files one can convert per day and it would give me even more reasons to love IT-Tools. No hurry, but if someone finds the time to resolve the conflicts and merge the PR, I (and presumably many others) would greatly appreciate it! Thank you! ❤️

@sharevb
Copy link
Contributor Author

sharevb commented Dec 11, 2024

Hi, for people interested in up to date version of it-tools, I made kind of a fork here : https://github.com/sharevb/it-tools (https://sharevb-it-tools.vercel.app/ and docker images https://github.com/sharevb/it-tools/pkgs/container/it-tools)

Copy link

vercel bot commented Dec 11, 2024

@sharevb is attempting to deploy a commit to the Corentin Thomasset's Team Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG2ICO conversion
3 participants