Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new tool): Random MAC address generator #657

Merged
merged 7 commits into from
Oct 31, 2023
Merged

feat(new tool): Random MAC address generator #657

merged 7 commits into from
Oct 31, 2023

Conversation

istvan-olah
Copy link
Contributor

@istvan-olah istvan-olah commented Oct 10, 2023

Hello!

This tools is something that I use sometimes at work, and thought it would be a great addition here. I reused an already open ticket for this tool type and added some more customization to the initial ticket.

I'm a backend dev, plus this is my first vue project that I opened, so please let me know if I made a mistake somewhere.

I used WebStorm but ommited every other TS file which was modified by the editor

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Oct 31, 2023 11:29am

@istvan-olah
Copy link
Contributor Author

@CorentinTh could you have a look at the PR please?

@istvan-olah istvan-olah changed the title #521 Random MAC address generator feat(new tool): Random MAC address generator Oct 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CorentinTh
Copy link
Owner

Hi @istvan-olah
Thank you for the new tool ! 🙏🏻
Sorry for the huge review delay 🥺

I made some small changes to improve a bit the ux and add more controle

screely-1698751473372

@CorentinTh CorentinTh enabled auto-merge (squash) October 31, 2023 11:29
@CorentinTh CorentinTh merged commit cc3425d into CorentinTh:main Oct 31, 2023
6 checks passed
@webysther
Copy link

Closes #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants