-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sponge platform #78
base: dev/0.3.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. Here is my rough review.
Important: please format the code properly.
api/src/main/kotlin/dev/cubxity/plugins/metrics/api/platform/PlatformType.kt
Outdated
Show resolved
Hide resolved
api/src/main/kotlin/dev/cubxity/plugins/metrics/api/platform/PlatformType.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Show resolved
Hide resolved
platforms/sponge/src/main/java/dev/cubxity/metrics/sponge/metric/events/EventsCollection.kt
Outdated
Show resolved
Hide resolved
platforms/sponge/src/main/java/dev/cubxity/metrics/sponge/metric/tick/TickReporter.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is still not formatted properly.
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Outdated
Show resolved
Hide resolved
...s/sponge/src/main/java/dev/cubxity/metrics/sponge/bootstrap/UnifiedMetricsSpongeBootstrap.kt
Show resolved
Hide resolved
This reverts commit 66d940c.
@Cubxity anything else you want? |
Adds support for sponge platform. I've only tested through influx dashboard. Needs testing in grafana. Aims to solve #21