Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable BetterHtml on Rails error pages #1884

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

peteryates
Copy link
Member

It prevents the web console from being rendered and just shows the default uninformative error screen.

More info here: Shopify/better-html#50

@github-actions github-actions bot added Config ruby Pull requests that update Ruby code labels Oct 18, 2021
@peteryates peteryates requested a review from ethax-ross October 18, 2021 16:07
ethax-ross
ethax-ross previously approved these changes Oct 18, 2021
Copy link
Contributor

@ethax-ross ethax-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice one, I was wondering what had caused this earlier 👍

It prevents the web console from being rendered and just shows the
default uninformative error screen.

More info here: Shopify/better-html#50
@peteryates peteryates force-pushed the disable-better-html-for-rails-pages branch from edcd78c to d4720e1 Compare October 19, 2021 16:19
@peteryates peteryates merged commit f9bb890 into master Oct 20, 2021
@peteryates peteryates deleted the disable-better-html-for-rails-pages branch October 20, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants