-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization Issue #486 #666
Localization Issue #486 #666
Conversation
Small fixes like grammar and markdown formatting
Fixed Image Links by including images with project |
@david-poindexter is /images/something.jpg ok here or do they need to be ../images/something.jpg ? |
I don't know for sure. I just copied what another page was doing and flipped it into preview mode to make sure it works. Since it worked in preview mode it probably should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My sincere apologies for the delayed response. I just discovered an email rule issue on my machine for this repo. I have reviewed the PR and will approve/merge it. Thanks @SmallMistake for the contribution - this is GREAT! 🎉
@valadas as a reminder, we still have this CI/CD issue to look into to ensure success with publishing this. I had forgotten that, so let me know when you have some time and we can double-team this one. I think we should hold off merging this until we get the build issue resolved. Otherwise, it will not be published on the site. |
@david-poindexter yeah, I honestly don't remember what the issue was, I'll submit a test PR just to get fresh build logs as the existing ones expired :) |
Continuation of the request for help translating a blog on Localization to a guide under the content management tab:
#486 (Localization)
I based it largely off of the guide outlined in the thread and my very limited experience so I might have overlooked something. Let me know if there are any areas that you think need any more explanation.