Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization Issue #486 #666

Merged
merged 8 commits into from
Aug 27, 2022

Conversation

SmallMistake
Copy link
Contributor

Continuation of the request for help translating a blog on Localization to a guide under the content management tab:
#486 (Localization)

I based it largely off of the guide outlined in the thread and my very limited experience so I might have overlooked something. Let me know if there are any areas that you think need any more explanation.

@SmallMistake
Copy link
Contributor Author

Fixed Image Links by including images with project

@valadas
Copy link
Member

valadas commented Mar 9, 2022

@david-poindexter is /images/something.jpg ok here or do they need to be ../images/something.jpg ?

@SmallMistake
Copy link
Contributor Author

I don't know for sure. I just copied what another page was doing and flipped it into preview mode to make sure it works. Since it worked in preview mode it probably should be fine.

Copy link
Collaborator

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My sincere apologies for the delayed response. I just discovered an email rule issue on my machine for this repo. I have reviewed the PR and will approve/merge it. Thanks @SmallMistake for the contribution - this is GREAT! 🎉

@david-poindexter
Copy link
Collaborator

@valadas as a reminder, we still have this CI/CD issue to look into to ensure success with publishing this. I had forgotten that, so let me know when you have some time and we can double-team this one. I think we should hold off merging this until we get the build issue resolved. Otherwise, it will not be published on the site.

@valadas
Copy link
Member

valadas commented Jul 27, 2022

@david-poindexter yeah, I honestly don't remember what the issue was, I'll submit a test PR just to get fresh build logs as the existing ones expired :)

@david-poindexter david-poindexter merged commit 681f187 into DNNCommunity:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants