Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNN 5 SKOs #730

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

Timo-Breumelhof
Copy link
Contributor

@Timo-Breumelhof Timo-Breumelhof commented Oct 2, 2024

I realize this is again quite a large PR. :-)
I went through https://www.timo-design.nl/Portals/0/downloads/DotNetNuke-Skin-Objects-DNN5.pdf and added all SKOs that are still valid..
When this is integrated I'll redirect that URL to DNNDOCS.

I checked the markdown, but it would be nice if someone could check my work too.
It was quite a bit of work and I'm seeing stars now ;-)

FYI I prefer change-requests for any issue on one of the individual SKO pages as I generate the MD from an Open Content template.

Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, just noted below something missing for the Logo one...

Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome awesome work @Timo-Breumelhof 🎉

@david-poindexter david-poindexter merged commit 83512c9 into DNNCommunity:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants