Support dedicated installation package directory #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned-up CommandlineOptions class and added short names for options. Furthermore, added option "packages-directory" to defines a directory, from which install packages will be read.
Extended App.config by possibility to configure PackagesDirectory path.
Introduced PackagesCrawler to encapsulate logic that will read all installation packages full file paths. It enables the DeployClient to read installation packages from a defined directory. It's no more necessary to save installation packages beside the DeployClient.exe. Encapsulated code in own method, that will write packages information to console and cancels the execution if no packages were found in packages directory, to get better readable code. Added unit tests for new PackagesCrawler component. Migrated Solution to Visual Studio 2019. Updated DeployClient project to .Net Framework 4.8 to get it up to date. Related issue: DNNCommunity#26
bdukes
approved these changes
Jun 8, 2020
|
This appears to also be related to my Issue #59. I'll close that now. :) |
|
I'm surprised at the fact, that such small PR needs more than 3 months to be reviewed. |
mitchelsellers
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
PackagesCrawlerto encapsulate logic that will read all installation packages full file paths. It enables theDeployClientto read installation packages from a defined directory. It's no more necessary to save installation packages beside theDeployClient.Encapsulated code in own method, that will write packages information to
console and cancels the execution if no packages were found in packages
directory, to get better readable code.
Added unit tests for new PackagesCrawler component.
Cleaned-up CommandlineOptions class and added short names for options.
Furthermore, added option "
packages-directory" to defines a directory,from which install packages will be read.
Extended
App.configby possibility to configurePackagesDirectorypath.Migrated Solution to Visual Studio 2019.
Updated DeployClient project to .Net Framework 4.8 to get it up to date.
Related issue: #26