Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql grammar #336

Merged
merged 3 commits into from
Aug 1, 2024
Merged

mysql grammar #336

merged 3 commits into from
Aug 1, 2024

Conversation

liuxy0551
Copy link
Collaborator

主要变更

@liuxy0551 liuxy0551 changed the base branch from next to main July 31, 2024 10:53
@Cythia828
Copy link
Collaborator

+1

@@ -36,4 +36,4 @@ SHOW CREATE SCHEMA IF NOT EXISTS db_name;

DROP SCHEMA IF EXISTS db_name;

CREATE FUNCTION IF NOT EXISTS my_concat_ws RETURNS STRING SONAME 'udf_my_concat_ws.so';
CREATE DEFINER = 'user' FUNCTION hello (s CHAR(20)) RETURNS CHAR(50) DETERMINISTIC RETURN CONCAT('Hello, ',s,'!');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是否应该将SONAME string和RETURN的两种sql都保留作为测试?

Copy link
Collaborator

@LuckyFBB LuckyFBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cythia828 Cythia828 merged commit 6176339 into DTStack:main Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants