More bug fixes ... #299
Merged
More bug fixes ... #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
krishmaj
commented
Jan 1, 2025
krishmaj
commented
- additional fix for missing component names ... now accounting for if the 'data.name' field is completely missing
- attempting fix for missing reception information when submitting components via the M2M system ... when doing so, the client-side URL that is supposed to assign sub-component location and date parameters is bypassed, and so these fields end up being 'null' - this change moves that assignment to the server-side library function, so it should be done regardless of whether the component is submitted via the interface or via M2M
- added some comments in the Formio ComponentUUID entity code to explain a certain console error that can sometimes show up ... no actual fix needed, just an explanation for future reference
- additional fix for missing component names ... now accounting for if the 'data.name' field is completely missing - attempting fix for missing reception information when submitting components via the M2M system ... when doing so, the client-side URL that is supposed to assign sub-component location and date parameters is bypassed, and so these fields end up being 'null' - this change moves that assignment to the server-side library function, so it should be done regardless of whether the component is submitted via the interface or via M2M - added some comments in the Formio ComponentUUID entity code to explain a certain console error that can sometimes show up ... no actual fix needed, just an explanation for future reference
bjrebel
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.