Skip to content

Commit

Permalink
CodeHealth: Remove use of ListValue::AppendStrings
Browse files Browse the repository at this point in the history
This change removes the use of `ListValue::AppendStrings()`
and replaces with `Value::Append()`.

This CL was uploaded by git cl split.

[email protected]

Bug: 1187103
Change-Id: I1223862961e675db839326e4fd216353136ec0f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2891655
Auto-Submit: Anastasiia N <[email protected]>
Commit-Queue: Kyle Horimoto <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/heads/master@{#882083}
  • Loading branch information
Anastasiia N authored and Chromium LUCI CQ committed May 12, 2021
1 parent 5547016 commit 508c4a8
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,9 @@ void CupsPrintersHandler::ResolveManufacturersDone(
const std::vector<std::string>& manufacturers) {
auto manufacturers_value = std::make_unique<base::ListValue>();
if (result_code == PpdProvider::SUCCESS) {
manufacturers_value->AppendStrings(manufacturers);
for (const std::string& manufacturer : manufacturers) {
manufacturers_value->Append(manufacturer);
}
}
base::DictionaryValue response;
response.SetBoolean("success", result_code == PpdProvider::SUCCESS);
Expand Down

0 comments on commit 508c4a8

Please sign in to comment.