Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to mandatory issue templates #8106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Switch to mandatory issue templates #8106

wants to merge 5 commits into from

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Dec 17, 2024 •
edited by jira bot
Loading

What Does This Do

  • standardizes the issue creation screen
  • standardizes the security policy document
  • makes issue templates mandatory
  • creates a bug report and feature request issue template

Motivation

  • standardizes the create issue screen across tracers

Additional Notes

Contributor Checklist

Jira ticket: AIDM-429

@tlhunter tlhunter added type: documentation tag: no release notes Changes to exclude from release notes labels Dec 17, 2024
@tlhunter tlhunter requested a review from a team as a code owner December 17, 2024 22:33
@tlhunter tlhunter requested a review from amarziali December 17, 2024 22:33
@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tlhunter/create-issue-standard
git_commit_date 1734727199 1734729241
git_commit_sha 37acd7b 6014e5c
release_version 1.45.0-SNAPSHOT~37acd7bbca 1.45.0-SNAPSHOT~6014e5c243
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734731703 1734731703
ci_job_id 747524383 747524383
ci_pipeline_id 51682048 51682048
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 6 performance improvements and 14 performance regressions! Performance is the same for 36 metrics, 7 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Agent.start worse
[+35.852ms; +69.874ms] or [+3.048%; +5.941%]		 1.229s 1.176s
scenario:startup:insecure-bank:iast:GlobalTracer worse
[+58.678ms; +66.229ms] or [+23.860%; +26.931%]		 308.375ms 245.922ms
scenario:startup:insecure-bank:iast:Remote Config better
[-69.259µs; -21.533µs] or [-10.412%; -3.237%]		 619.812µs 665.208µs
scenario:startup:insecure-bank:iast:Telemetry better
[-1127.093µs; -596.150µs] or [-13.360%; -7.067%]		 7.575ms 8.436ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:GlobalTracer worse
[+53.499ms; +61.645ms] or [+21.408%; +24.668%]		 307.472ms 249.900ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Remote Config better
[-90.369µs; -28.229µs] or [-13.467%; -4.207%]		 611.718µs 671.017µs
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Telemetry better
[-1278.649µs; -704.636µs] or [-14.928%; -8.226%]		 7.574ms 8.566ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Agent.start worse
[+38.631ms; +72.787ms] or [+3.293%; +6.204%]		 1.229s 1.173s
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:GlobalTracer worse
[+59.338ms; +66.989ms] or [+24.087%; +27.193%]		 309.509ms 246.345ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry better
[-1001.099µs; -649.135µs] or [-12.071%; -7.827%]		 7.468ms 8.293ms
scenario:startup:insecure-bank:tracing:Agent.start worse
[+39.381ms; +50.794ms] or [+3.744%; +4.829%]		 1.097s 1.052s
scenario:startup:insecure-bank:tracing:GlobalTracer worse
[+61.525ms; +64.391ms] or [+24.075%; +25.197%]		 318.511ms 255.553ms
scenario:startup:petclinic:appsec:Agent.start worse
[+35.266ms; +49.415ms] or [+2.975%; +4.168%]		 1.228s 1.185s
scenario:startup:petclinic:appsec:GlobalTracer worse
[+60.301ms; +64.727ms] or [+23.840%; +25.590%]		 315.451ms 252.936ms
scenario:startup:petclinic:iast:GlobalTracer worse
[+56.685ms; +62.240ms] or [+22.841%; +25.079%]		 307.633ms 248.170ms
scenario:startup:petclinic:iast:Telemetry better
[-1.380ms; -0.774ms] or [-16.103%; -9.024%]		 7.495ms 8.572ms
scenario:startup:petclinic:profiling:Agent.start worse
[+44.417ms; +52.842ms] or [+3.489%; +4.151%]		 1.322s 1.273s
scenario:startup:petclinic:profiling:GlobalTracer worse
[+61.968ms; +67.409ms] or [+16.673%; +18.137%]		 436.356ms 371.667ms
scenario:startup:petclinic:tracing:Agent.start worse
[+27.210ms; +47.112ms] or [+2.573%; +4.456%]		 1.095s 1.057s
scenario:startup:petclinic:tracing:GlobalTracer worse
[+61.081ms; +63.157ms] or [+23.852%; +24.663%]		 318.197ms 256.078ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051793
Total [baseline] (8.639 s) : 0, 8638514
Agent [candidate] (1.097 s) : 0, 1096881
Total [candidate] (8.645 s) : 0, 8645074
section iast
Agent [baseline] (1.176 s) : 0, 1176135
Total [baseline] (9.203 s) : 0, 9202935
Agent [candidate] (1.229 s) : 0, 1228998
Total [candidate] (9.263 s) : 0, 9263491
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.194 s) : 0, 1194351
Total [baseline] (9.212 s) : 0, 9211978
Agent [candidate] (1.225 s) : 0, 1224988
Total [candidate] (9.173 s) : 0, 9172943
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173179
Total [baseline] (9.195 s) : 0, 9195322
Agent [candidate] (1.229 s) : 0, 1228888
Total [candidate] (9.18 s) : 0, 9179741
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent iast 1.176 s 124.342 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.194 s 142.558 ms (13.6%)
Agent iast_TELEMETRY_OFF 1.173 s 121.386 ms (11.5%)
Total tracing 8.639 s -
Total iast 9.203 s 564.42 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.212 s 573.464 ms (6.6%)
Total iast_TELEMETRY_OFF 9.195 s 556.808 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent iast 1.229 s 132.117 ms (12.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.225 s 128.107 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.229 s 132.007 ms (12.0%)
Total tracing 8.645 s -
Total iast 9.263 s 618.417 ms (7.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.173 s 527.87 ms (6.1%)
Total iast_TELEMETRY_OFF 9.18 s 534.668 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (711.151 ms) : 0, 711151
BytebuddyAgent [candidate] (697.125 ms) : 0, 697125
GlobalTracer [baseline] (255.553 ms) : 0, 255553
GlobalTracer [candidate] (318.511 ms) : 0, 318511
AppSec [baseline] (57.698 ms) : 0, 57698
AppSec [candidate] (54.729 ms) : 0, 54729
Remote Config [baseline] (679.386 µs) : 0, 679
Remote Config [candidate] (664.693 µs) : 0, 665
Telemetry [baseline] (11.756 ms) : 0, 11756
Telemetry [candidate] (12.088 ms) : 0, 12088
section iast
BytebuddyAgent [baseline] (827.295 ms) : 0, 827295
BytebuddyAgent [candidate] (818.893 ms) : 0, 818893
GlobalTracer [baseline] (245.922 ms) : 0, 245922
GlobalTracer [candidate] (308.375 ms) : 0, 308375
AppSec [baseline] (57.698 ms) : 0, 57698
AppSec [candidate] (58.369 ms) : 0, 58369
IAST [baseline] (21.206 ms) : 0, 21206
IAST [candidate] (21.334 ms) : 0, 21334
Remote Config [baseline] (665.208 µs) : 0, 665
Remote Config [candidate] (619.812 µs) : 0, 620
Telemetry [baseline] (8.436 ms) : 0, 8436
Telemetry [candidate] (7.575 ms) : 0, 7575
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.248 ms) : 0, 840248
BytebuddyAgent [candidate] (815.876 ms) : 0, 815876
GlobalTracer [baseline] (249.9 ms) : 0, 249900
GlobalTracer [candidate] (307.472 ms) : 0, 307472
AppSec [baseline] (58.391 ms) : 0, 58391
AppSec [candidate] (56.694 ms) : 0, 56694
IAST [baseline] (21.424 ms) : 0, 21424
IAST [candidate] (22.947 ms) : 0, 22947
Remote Config [baseline] (671.017 µs) : 0, 671
Remote Config [candidate] (611.718 µs) : 0, 612
Telemetry [baseline] (8.566 ms) : 0, 8566
Telemetry [candidate] (7.574 ms) : 0, 7574
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (824.329 ms) : 0, 824329
BytebuddyAgent [candidate] (818.195 ms) : 0, 818195
GlobalTracer [baseline] (246.345 ms) : 0, 246345
GlobalTracer [candidate] (309.509 ms) : 0, 309509
AppSec [baseline] (57.814 ms) : 0, 57814
AppSec [candidate] (58.461 ms) : 0, 58461
IAST [baseline] (20.835 ms) : 0, 20835
IAST [candidate] (20.767 ms) : 0, 20767
Remote Config [baseline] (650.646 µs) : 0, 651
Remote Config [candidate] (613.683 µs) : 0, 614
Telemetry [baseline] (8.293 ms) : 0, 8293
Telemetry [candidate] (7.468 ms) : 0, 7468
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057339
Total [baseline] (10.46 s) : 0, 10460153
Agent [candidate] (1.095 s) : 0, 1094500
Total [candidate] (10.554 s) : 0, 10554443
section appsec
Agent [baseline] (1.185 s) : 0, 1185492
Total [baseline] (10.724 s) : 0, 10724474
Agent [candidate] (1.228 s) : 0, 1227832
Total [candidate] (10.681 s) : 0, 10680563
section iast
Agent [baseline] (1.186 s) : 0, 1186236
Total [baseline] (11.06 s) : 0, 11059652
Agent [candidate] (1.223 s) : 0, 1223350
Total [candidate] (11.007 s) : 0, 11007354
section profiling
Agent [baseline] (1.273 s) : 0, 1272933
Total [baseline] (10.878 s) : 0, 10877931
Agent [candidate] (1.322 s) : 0, 1321562
Total [candidate] (10.792 s) : 0, 10792369
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.185 s 128.152 ms (12.1%)
Agent iast 1.186 s 128.896 ms (12.2%)
Agent profiling 1.273 s 215.593 ms (20.4%)
Total tracing 10.46 s -
Total appsec 10.724 s 264.321 ms (2.5%)
Total iast 11.06 s 599.499 ms (5.7%)
Total profiling 10.878 s 417.778 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.095 s -
Agent appsec 1.228 s 133.332 ms (12.2%)
Agent iast 1.223 s 128.85 ms (11.8%)
Agent profiling 1.322 s 227.062 ms (20.7%)
Total tracing 10.554 s -
Total appsec 10.681 s 126.121 ms (1.2%)
Total iast 11.007 s 452.911 ms (4.3%)
Total profiling 10.792 s 237.926 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.171 ms) : 0, 715171
BytebuddyAgent [candidate] (696.545 ms) : 0, 696545
GlobalTracer [baseline] (256.078 ms) : 0, 256078
GlobalTracer [candidate] (318.197 ms) : 0, 318197
AppSec [baseline] (56.403 ms) : 0, 56403
AppSec [candidate] (54.663 ms) : 0, 54663
Remote Config [baseline] (679.309 µs) : 0, 679
Remote Config [candidate] (661.745 µs) : 0, 662
Telemetry [baseline] (13.959 ms) : 0, 13959
Telemetry [candidate] (10.627 ms) : 0, 10627
section appsec
BytebuddyAgent [baseline] (728.472 ms) : 0, 728472
BytebuddyAgent [candidate] (712.868 ms) : 0, 712868
GlobalTracer [baseline] (252.936 ms) : 0, 252936
GlobalTracer [candidate] (315.451 ms) : 0, 315451
AppSec [baseline] (170.933 ms) : 0, 170933
AppSec [candidate] (167.447 ms) : 0, 167447
Remote Config [baseline] (653.474 µs) : 0, 653
Remote Config [candidate] (657.548 µs) : 0, 658
Telemetry [baseline] (7.976 ms) : 0, 7976
Telemetry [candidate] (8.127 ms) : 0, 8127
IAST [baseline] (19.173 ms) : 0, 19173
IAST [candidate] (19.016 ms) : 0, 19016
section iast
BytebuddyAgent [baseline] (834.136 ms) : 0, 834136
BytebuddyAgent [candidate] (814.055 ms) : 0, 814055
GlobalTracer [baseline] (248.17 ms) : 0, 248170
GlobalTracer [candidate] (307.633 ms) : 0, 307633
AppSec [baseline] (58.287 ms) : 0, 58287
AppSec [candidate] (56.775 ms) : 0, 56775
Remote Config [baseline] (664.572 µs) : 0, 665
Remote Config [candidate] (609.192 µs) : 0, 609
Telemetry [baseline] (8.572 ms) : 0, 8572
Telemetry [candidate] (7.495 ms) : 0, 7495
IAST [baseline] (21.38 ms) : 0, 21380
IAST [candidate] (23.021 ms) : 0, 23021
section profiling
ProfilingAgent [baseline] (95.815 ms) : 0, 95815
ProfilingAgent [candidate] (94.047 ms) : 0, 94047
BytebuddyAgent [baseline] (701.022 ms) : 0, 701022
BytebuddyAgent [candidate] (689.609 ms) : 0, 689609
GlobalTracer [baseline] (371.667 ms) : 0, 371667
GlobalTracer [candidate] (436.356 ms) : 0, 436356
AppSec [baseline] (53.848 ms) : 0, 53848
AppSec [candidate] (53.941 ms) : 0, 53941
Remote Config [baseline] (643.726 µs) : 0, 644
Remote Config [candidate] (681.938 µs) : 0, 682
Telemetry [baseline] (7.845 ms) : 0, 7845
Telemetry [candidate] (7.727 ms) : 0, 7727
Profiling [baseline] (95.839 ms) : 0, 95839
Profiling [candidate] (94.073 ms) : 0, 94073
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-20T21:22:59 2024-12-20T21:30:00
git_branch master tlhunter/create-issue-standard
git_commit_date 1734727199 1734729241
git_commit_sha 37acd7b 6014e5c
release_version 1.45.0-SNAPSHOT~37acd7bbca 1.45.0-SNAPSHOT~6014e5c243
start_time 2024-12-20T21:22:45 2024-12-20T21:29:47
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1734730556 1734730556
ci_job_id 747524384 747524384
ci_pipeline_id 51682048 51682048
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.37 ms) : 1350, 1389
.   : milestone, 1370,
appsec (1.768 ms) : 1744, 1792
.   : milestone, 1768,
appsec_no_iast (1.769 ms) : 1744, 1794
.   : milestone, 1769,
iast (1.507 ms) : 1484, 1531
.   : milestone, 1507,
profiling (1.512 ms) : 1488, 1536
.   : milestone, 1512,
tracing (1.494 ms) : 1469, 1519
.   : milestone, 1494,
section candidate
no_agent (1.37 ms) : 1350, 1390
.   : milestone, 1370,
appsec (1.775 ms) : 1751, 1798
.   : milestone, 1775,
appsec_no_iast (1.764 ms) : 1739, 1789
.   : milestone, 1764,
iast (1.501 ms) : 1479, 1524
.   : milestone, 1501,
profiling (1.545 ms) : 1523, 1568
.   : milestone, 1545,
tracing (1.513 ms) : 1489, 1537
.   : milestone, 1513,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.35 ms, 1.389 ms] -
appsec 1.768 ms [1.744 ms, 1.792 ms] 398.343 µs (29.1%)
appsec_no_iast 1.769 ms [1.744 ms, 1.794 ms] 398.858 µs (29.1%)
iast 1.507 ms [1.484 ms, 1.531 ms] 137.68 µs (10.1%)
profiling 1.512 ms [1.488 ms, 1.536 ms] 141.982 µs (10.4%)
tracing 1.494 ms [1.469 ms, 1.519 ms] 124.352 µs (9.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.35 ms, 1.39 ms] -
appsec 1.775 ms [1.751 ms, 1.798 ms] 404.777 µs (29.5%)
appsec_no_iast 1.764 ms [1.739 ms, 1.789 ms] 393.929 µs (28.8%)
iast 1.501 ms [1.479 ms, 1.524 ms] 131.434 µs (9.6%)
profiling 1.545 ms [1.523 ms, 1.568 ms] 175.152 µs (12.8%)
tracing 1.513 ms [1.489 ms, 1.537 ms] 142.88 µs (10.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.644 µs) : 362, 401
.   : milestone, 382,
iast (497.35 µs) : 476, 519
.   : milestone, 497,
iast_FULL (661.563 µs) : 640, 683
.   : milestone, 662,
iast_GLOBAL (530.668 µs) : 508, 553
.   : milestone, 531,
iast_HARDCODED_SECRET_DISABLED (505.905 µs) : 484, 528
.   : milestone, 506,
iast_INACTIVE (466.714 µs) : 445, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (488.718 µs) : 467, 510
.   : milestone, 489,
tracing (457.784 µs) : 437, 479
.   : milestone, 458,
section candidate
no_agent (384.937 µs) : 365, 405
.   : milestone, 385,
iast (506.592 µs) : 485, 528
.   : milestone, 507,
iast_FULL (670.704 µs) : 649, 692
.   : milestone, 671,
iast_GLOBAL (530.639 µs) : 508, 553
.   : milestone, 531,
iast_HARDCODED_SECRET_DISABLED (499.464 µs) : 477, 522
.   : milestone, 499,
iast_INACTIVE (461.776 µs) : 441, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (488.063 µs) : 466, 510
.   : milestone, 488,
tracing (457.894 µs) : 436, 479
.   : milestone, 458,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.644 µs [361.848 µs, 401.44 µs] -
iast 497.35 µs [475.712 µs, 518.989 µs] 115.707 µs (30.3%)
iast_FULL 661.563 µs [640.082 µs, 683.044 µs] 279.919 µs (73.3%)
iast_GLOBAL 530.668 µs [508.316 µs, 553.02 µs] 149.024 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED 505.905 µs [483.911 µs, 527.899 µs] 124.261 µs (32.6%)
iast_INACTIVE 466.714 µs [444.671 µs, 488.758 µs] 85.071 µs (22.3%)
iast_TELEMETRY_OFF 488.718 µs [467.357 µs, 510.08 µs] 107.075 µs (28.1%)
tracing 457.784 µs [436.837 µs, 478.731 µs] 76.14 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.937 µs [364.863 µs, 405.01 µs] -
iast 506.592 µs [484.786 µs, 528.398 µs] 121.655 µs (31.6%)
iast_FULL 670.704 µs [649.11 µs, 692.297 µs] 285.767 µs (74.2%)
iast_GLOBAL 530.639 µs [508.368 µs, 552.911 µs] 145.703 µs (37.9%)
iast_HARDCODED_SECRET_DISABLED 499.464 µs [477.409 µs, 521.518 µs] 114.527 µs (29.8%)
iast_INACTIVE 461.776 µs [440.535 µs, 483.016 µs] 76.839 µs (20.0%)
iast_TELEMETRY_OFF 488.063 µs [466.322 µs, 509.803 µs] 103.126 µs (26.8%)
tracing 457.894 µs [436.49 µs, 479.298 µs] 72.957 µs (19.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tlhunter/create-issue-standard
git_commit_date 1734727199 1734729241
git_commit_sha 37acd7b 6014e5c
release_version 1.45.0-SNAPSHOT~37acd7bbca 1.45.0-SNAPSHOT~6014e5c243
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1734731113 1734731113
ci_job_id 747524385 747524385
ci_pipeline_id 51682048 51682048
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.891 s) : 14891000, 14891000
.   : milestone, 14891000,
appsec (14.777 s) : 14777000, 14777000
.   : milestone, 14777000,
iast (18.902 s) : 18902000, 18902000
.   : milestone, 18902000,
iast_GLOBAL (17.705 s) : 17705000, 17705000
.   : milestone, 17705000,
profiling (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
tracing (15.172 s) : 15172000, 15172000
.   : milestone, 15172000,
section candidate
no_agent (15.586 s) : 15586000, 15586000
.   : milestone, 15586000,
appsec (14.914 s) : 14914000, 14914000
.   : milestone, 14914000,
iast (18.473 s) : 18473000, 18473000
.   : milestone, 18473000,
iast_GLOBAL (17.824 s) : 17824000, 17824000
.   : milestone, 17824000,
profiling (15.365 s) : 15365000, 15365000
.   : milestone, 15365000,
tracing (14.927 s) : 14927000, 14927000
.   : milestone, 14927000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.891 s [14.891 s, 14.891 s] -
appsec 14.777 s [14.777 s, 14.777 s] -114.0 ms (-0.8%)
iast 18.902 s [18.902 s, 18.902 s] 4.011 s (26.9%)
iast_GLOBAL 17.705 s [17.705 s, 17.705 s] 2.814 s (18.9%)
profiling 15.084 s [15.084 s, 15.084 s] 193.0 ms (1.3%)
tracing 15.172 s [15.172 s, 15.172 s] 281.0 ms (1.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.586 s [15.586 s, 15.586 s] -
appsec 14.914 s [14.914 s, 14.914 s] -672.0 ms (-4.3%)
iast 18.473 s [18.473 s, 18.473 s] 2.887 s (18.5%)
iast_GLOBAL 17.824 s [17.824 s, 17.824 s] 2.238 s (14.4%)
profiling 15.365 s [15.365 s, 15.365 s] -221.0 ms (-1.4%)
tracing 14.927 s [14.927 s, 14.927 s] -659.0 ms (-4.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6014e5c243, baseline=1.45.0-SNAPSHOT~37acd7bbca
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.352 ms) : 2310, 2393
.   : milestone, 2352,
iast (2.091 ms) : 2037, 2144
.   : milestone, 2091,
iast_GLOBAL (2.142 ms) : 2089, 2196
.   : milestone, 2142,
profiling (2.422 ms) : 2235, 2608
.   : milestone, 2422,
tracing (1.933 ms) : 1892, 1974
.   : milestone, 1933,
section candidate
no_agent (1.466 ms) : 1455, 1477
.   : milestone, 1466,
appsec (2.347 ms) : 2305, 2389
.   : milestone, 2347,
iast (2.096 ms) : 2042, 2150
.   : milestone, 2096,
iast_GLOBAL (2.136 ms) : 2083, 2190
.   : milestone, 2136,
profiling (1.971 ms) : 1927, 2015
.   : milestone, 1971,
tracing (1.94 ms) : 1899, 1980
.   : milestone, 1940,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 2.352 ms [2.31 ms, 2.393 ms] 881.787 µs (60.0%)
iast 2.091 ms [2.037 ms, 2.144 ms] 620.876 µs (42.2%)
iast_GLOBAL 2.142 ms [2.089 ms, 2.196 ms] 672.565 µs (45.8%)
profiling 2.422 ms [2.235 ms, 2.608 ms] 952.078 µs (64.8%)
tracing 1.933 ms [1.892 ms, 1.974 ms] 463.047 µs (31.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.455 ms, 1.477 ms] -
appsec 2.347 ms [2.305 ms, 2.389 ms] 881.009 µs (60.1%)
iast 2.096 ms [2.042 ms, 2.15 ms] 629.856 µs (43.0%)
iast_GLOBAL 2.136 ms [2.083 ms, 2.19 ms] 670.378 µs (45.7%)
profiling 1.971 ms [1.927 ms, 2.015 ms] 504.989 µs (34.4%)
tracing 1.94 ms [1.899 ms, 1.98 ms] 473.539 µs (32.3%)

@PerfectSlayer PerfectSlayer self-requested a review December 18, 2024 07:31
PerfectSlayer
PerfectSlayer reviewed Dec 18, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yaml
@@ -0,0 +1,34 @@
name: "Bug Report (Low Priority)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the low / high priority wording approved as a public facing support level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We came up with it during the ideation phase a quarter ago, I believe the OSS team looked it over, and the Node.js tracer has been using it for months.

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml
@@ -1,8 +1,8 @@
blank_issues_enabled: true
blank_issues_enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about all the other types of issue? Performance discussions, questions, help requests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add additional templates for them. Other tracers either don't support freeform discussion or use the discussions tab. Are those three topics the finite list that you would like supported? Also, what default tags would you want applied?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it’s mainly performance related, or a question / help request.
I don’t know how the other tracers are handling it using GitHub?

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
@PerfectSlayer PerfectSlayer changed the title repo: mandatory issue templates (AIDM-429) Switch to mandatory issue templates Dec 18, 2024
@tlhunter tlhunter force-pushed the tlhunter/create-issue-standard branch from 4a073d2 to e20b4cf Compare December 18, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali left review comments

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tag: no release notes Changes to exclude from release notes type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlhunter @PerfectSlayer @amarziali