Skip to content

Commit

Permalink
Include feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
pierotibou committed Dec 12, 2023
1 parent f192000 commit c40d316
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
12 changes: 9 additions & 3 deletions content/en/tracing/trace_collection/compatibility/dotnet-core.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,14 @@ Don't see your desired libraries? You can check whether the library emits Open T

Some libraries provide built in [Activity based tracing][13]. This is the same mechanism the OpenTelemetry project relies on. By setting `DD_TRACE_OTEL_ENABLED` to `true`, the .NET tracer will automatically resurface traces provided by the libraries themselves. This is possible since [version 2.21.0][4]. Here are a list of libraries that are tested with this setup (more libraries provide such tracing though, they aren't yet expliciitly tested).

Check warning on line 96 in content/en/tracing/trace_collection/compatibility/dotnet-core.md

View workflow job for this annotation

GitHub Actions / vale

[vale] content/en/tracing/trace_collection/compatibility/dotnet-core.md#L96

[Datadog.headings] 'OTEL based integrations' should use sentence-style capitalization.
Raw output
{"message": "[Datadog.headings] 'OTEL based integrations' should use sentence-style capitalization.", "location": {"path": "content/en/tracing/trace_collection/compatibility/dotnet-core.md", "range": {"start": {"line": 96, "column": 4}}}, "severity": "WARNING"}
| Framework or library | NuGet package | Integration Name |
| ------------------------------- | ---------------------------------------------------------------------------------------------------- | -------------------- |
| Azure Service Bus | Azure.Messaging.ServiceBus | `AzureServiceBus` |
| Framework or library | NuGet package | Integration Name | Specific instructions |
| ------------------------------- | ----------------------------------------------------------------------------- | -------------------- | ----------------------------- |

Check warning on line 98 in content/en/tracing/trace_collection/compatibility/dotnet-core.md

View workflow job for this annotation

GitHub Actions / vale

[vale] content/en/tracing/trace_collection/compatibility/dotnet-core.md#L98

[Datadog.tense] Avoid temporal words like 'will'.
Raw output
{"message": "[Datadog.tense] Avoid temporal words like 'will'.", "location": {"path": "content/en/tracing/trace_collection/compatibility/dotnet-core.md", "range": {"start": {"line": 98, "column": 189}}}, "severity": "WARNING"}
| Azure Service Bus | `Azure.Messaging.ServiceBus` 7.14.0+ | `AzureServiceBus` | See `Azure SDK` section below |

### Azure SDK

Azure SDK provides built in OpenTelemety support. It requires to be enabled by setting `AZURE_EXPERIMENTAL_ENABLE_ACTIVITY_SOURCE` environment variable to true or by setting the `Azure.Experimental.EnableActivitySource` context switch to true in your application code. See [Azuze SDK documentation][14] for more details.

Check warning on line 104 in content/en/tracing/trace_collection/compatibility/dotnet-core.md

View workflow job for this annotation

GitHub Actions / vale

[vale] content/en/tracing/trace_collection/compatibility/dotnet-core.md#L104

[Datadog.headings] 'Azure SDK' should use sentence-style capitalization.
Raw output
{"message": "[Datadog.headings] 'Azure SDK' should use sentence-style capitalization.", "location": {"path": "content/en/tracing/trace_collection/compatibility/dotnet-core.md", "range": {"start": {"line": 104, "column": 5}}}, "severity": "WARNING"}

## End of life .NET Core versions

Expand Down Expand Up @@ -155,3 +160,4 @@ Version updates imply the following changes to runtime support:
[11]: https://semver.org/
[12]: https://www.nuget.org/packages/Datadog.Trace.Trimming/
[13]: https://learn.microsoft.com/en-us/dotnet/core/diagnostics/distributed-tracing
[14]: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/Diagnostics.md#enabling-experimental-tracing-features
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,13 @@ Don't see your desired libraries? You can check whether the library emits Open T

Some libraries provide built in [Activity based tracing][11]. This is the same mechanism the OpenTelemetry project relies on. By setting `DD_TRACE_OTEL_ENABLED` to `true`, the .NET tracer will automatically resurface traces provided by the libraries themselves. This is possible since [version 2.21.0][4]. Here are a list of libraries that are tested with this setup (more libraries provide such tracing though, they aren't yet expliciitly tested).

Check warning on line 96 in content/en/tracing/trace_collection/compatibility/dotnet-framework.md

View workflow job for this annotation

GitHub Actions / vale

[vale] content/en/tracing/trace_collection/compatibility/dotnet-framework.md#L96

[Datadog.headings] 'OTEL based integrations' should use sentence-style capitalization.
Raw output
{"message": "[Datadog.headings] 'OTEL based integrations' should use sentence-style capitalization.", "location": {"path": "content/en/tracing/trace_collection/compatibility/dotnet-framework.md", "range": {"start": {"line": 96, "column": 4}}}, "severity": "WARNING"}
| Framework or library | NuGet package | Integration Name |
| ------------------------------- | ---------------------------------------------------------------------------------------------------- | -------------------- |
| Azure Service Bus | Azure.Messaging.ServiceBus | `AzureServiceBus` |
| Framework or library | NuGet package | Integration Name | Specific instructions |
| ------------------------------- | ----------------------------------------------------------------------------- | -------------------- | ----------------------------- |

Check warning on line 98 in content/en/tracing/trace_collection/compatibility/dotnet-framework.md

View workflow job for this annotation

GitHub Actions / vale

[vale] content/en/tracing/trace_collection/compatibility/dotnet-framework.md#L98

[Datadog.tense] Avoid temporal words like 'will'.
Raw output
{"message": "[Datadog.tense] Avoid temporal words like 'will'.", "location": {"path": "content/en/tracing/trace_collection/compatibility/dotnet-framework.md", "range": {"start": {"line": 98, "column": 189}}}, "severity": "WARNING"}
| Azure Service Bus | `Azure.Messaging.ServiceBus` 7.14.0+ | `AzureServiceBus` | See `Azure SDK` section below |

### Azure SDK

Azure SDK provides built in OpenTelemety support. It requires to be enabled by setting `AZURE_EXPERIMENTAL_ENABLE_ACTIVITY_SOURCE` environment variable to true or by setting the `Azure.Experimental.EnableActivitySource` context switch to true in your application code. See [Azuze SDK documentation][12] for more details.

## Supported Datadog Agent versions

Expand Down Expand Up @@ -144,3 +148,4 @@ Version updates imply the following changes to runtime support:
[9]: https://www.datadoghq.com/support/
[10]: https://semver.org/
[11]: https://learn.microsoft.com/en-us/dotnet/core/diagnostics/distributed-tracing
[12]: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/Diagnostics.md#enabling-experimental-tracing-features

0 comments on commit c40d316

Please sign in to comment.