-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM][Tracing] Add documentation for DD_TRACE_OTEL_ENABLED
and related integrations
#20107
Conversation
Hey Pierre, the application also needs to add a setting so that the Azure SDK will generate OpenTelemetry spans to begin with: https://devblogs.microsoft.com/azure-sdk/introducing-experimental-opentelemetry-support-in-the-azure-sdk-for-net/ |
For reference, in our .NET Tracer samples we use the |
Added DOCS-6901 to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .NET content looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this content! Please see a few of my suggestions and questions for consideration. 🙏
content/en/tracing/trace_collection/compatibility/dotnet-core.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/compatibility/dotnet-core.md
Outdated
Show resolved
Hide resolved
|
||
## OTEL based integrations | ||
|
||
Some libraries provide built in [Activity based tracing][13]. This is the same mechanism the OpenTelemetry project relies on. By setting `DD_TRACE_OTEL_ENABLED` to `true`, the .NET tracer will automatically resurface traces provided by the libraries themselves. This is possible since [version 2.21.0][4]. Here are a list of libraries that are tested with this setup (more libraries provide such tracing though, they aren't yet expliciitly tested). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some libraries provide built in [Activity based tracing][13]. This is the same mechanism the OpenTelemetry project relies on. By setting `DD_TRACE_OTEL_ENABLED` to `true`, the .NET tracer will automatically resurface traces provided by the libraries themselves. This is possible since [version 2.21.0][4]. Here are a list of libraries that are tested with this setup (more libraries provide such tracing though, they aren't yet expliciitly tested). | |
Some libraries provide built-in [Activity based tracing][13]. This is the same mechanism that OpenTelemetry is based on. | |
For these libraries, set `DD_TRACE_OTEL_ENABLED` to `true`, and the .NET tracer automatically captures traces their traces. This is supported since [version 2.21.0][4]. | |
The following list of libraries have been tested with this setup: |
Is the distinction about Activity-based tracing important, or could we simply say "Some libraries provide built-in support for OpenTelemetry"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it's not that important. we could maybe switch to talking about OpenTelemetry only. @zacharycmontoya will know better though
content/en/tracing/trace_collection/compatibility/dotnet-core.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/compatibility/dotnet-framework.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/compatibility/dotnet-framework.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/compatibility/dotnet-framework.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/compatibility/dotnet-framework.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/library_config/dotnet-core.md
Outdated
Show resolved
Hide resolved
content/en/tracing/trace_collection/library_config/dotnet-framework.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Brett Blue <[email protected]>
Thanks a lot @brett0000FF, I had completely missed your review and just realized today this hadn't been merged. |
Thanks again @brett0000FF ! |
What does this PR do? What is the motivation?
Documents
DD_TRACE_OTEL_ENABLED
. It also starts listing integrations that we explicitly test with this setup.I've chosen to list those in a separated table to better explain the need to set DD_TRACE_OTEL_ENABLED to true. But maybe one table with an extra column would be better?
Merge instructions
Additional notes