-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static analysis pg updates - [WEB-3971] #20119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
StefonSimmons
changed the title
Stefon.simmons/static analysis pg updates
static analysis pg updates - [WEB-3971]
Oct 13, 2023
…m:DataDog/documentation into stefon.simmons/static-analysis-pg-updates
aaxzheng
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality seems to work as suggested. LGTM
cswatt
approved these changes
Dec 12, 2023
MaelNamNam
pushed a commit
that referenced
this pull request
Jan 17, 2024
* source comment * rm unused shortcode * init static analysis * add filter btns * multi-filtering works. search bar added * remove rule and associated ruleset * filter and search work together * updating url params * update x-data w/ url params * use ruleset id; look at main branch * fix search * further styling * further styling group description * toggle ruleset arraw * mobile view * responsive to mobile * cleanup * rule hover state * adjust arrow on active header * add copy icon and language logos * filter forms init * fix grouper-header styles * toggle and style the new filter forms * overflow gradient * use `cancel-circle` icon * adjust logo sizing * adjust filter type keys and overflow gradient * restructure this.filterValue for multiple selections via input * select and delete one * load integration logo in Languages selections * update pushstate and pull state * switch checkbox evnt listener. cond render cancel circle * rm content from master merge * adjust filter logic. allow multiple select of a filter type * update comments. fix deleteOneSelection * comments and name changes * selection-container overflow and mobile filter * prevent default * comment * empty results message * validate the `languages` url param * reorder Severity by decending severity * stop propogation on toggler outside click * filter form id * data-id selection-container * close-light data-id * ruleset description markdownify * comment * update rulesets with yaml * used `severities` info from source. * $watch 'filteredRulesets' to load empty res msg * class name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
updates the ui for the static analysis page:
reduces line count in
/continuous_integration/static_analysis/rules/_index.md
by extracting rule info from pulled in content (i.e. thedatadog-static-analyzer-rule-docs
repo).removes
layouts/shortcodes/staticanalysisrule.html
andlayouts/shortcodes/statticanalysisruleset.html
shortcodeshttps://datadoghq.atlassian.net/jira/software/projects/WEB/boards/102?selectedIssue=WEB-3971
Merge instructions
Additional notes