Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static analysis pg updates - [WEB-3971] #20119

Merged
merged 55 commits into from
Dec 12, 2023

Conversation

StefonSimmons
Copy link
Contributor

@StefonSimmons StefonSimmons commented Oct 10, 2023

What does this PR do? What is the motivation?

updates the ui for the static analysis page:

  • adds ability to toggle rulesets.
  • filter via search bar for rulesets
  • filter via three categories (Languages, Severities, Categories)
  • filter and search values are appended to url parameters for sharing

reduces line count in /continuous_integration/static_analysis/rules/_index.md by extracting rule info from pulled in content (i.e. the datadog-static-analyzer-rule-docs repo).

removes layouts/shortcodes/staticanalysisrule.html and layouts/shortcodes/statticanalysisruleset.htmlshortcodes

https://datadoghq.atlassian.net/jira/software/projects/WEB/boards/102?selectedIssue=WEB-3971

Merge instructions

  • Please merge after Corp Web and Static Analysis review

Additional notes

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Preview links (active after the build_preview check completes)

Modified Files

@StefonSimmons StefonSimmons changed the title Stefon.simmons/static analysis pg updates static analysis pg updates - [WEB-3971] Oct 13, 2023
@StefonSimmons StefonSimmons marked this pull request as ready for review December 12, 2023 15:13
@StefonSimmons StefonSimmons requested review from a team as code owners December 12, 2023 15:13
Copy link
Contributor

@aaxzheng aaxzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to work as suggested. LGTM

@cswatt cswatt merged commit eb72698 into master Dec 12, 2023
16 of 17 checks passed
@cswatt cswatt deleted the stefon.simmons/static-analysis-pg-updates branch December 12, 2023 17:53
@StefonSimmons StefonSimmons mentioned this pull request Dec 12, 2023
1 task
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
* source comment

* rm unused shortcode

* init static analysis

* add filter btns

* multi-filtering works. search bar added

* remove rule and associated  ruleset

* filter and search work together

* updating url params

* update x-data w/ url params

* use ruleset id; look at main branch

* fix search

* further styling

* further styling group description

* toggle ruleset arraw

* mobile view

* responsive to mobile

* cleanup

* rule hover state

* adjust arrow on active header

* add copy icon and language logos

* filter forms init

* fix grouper-header styles

* toggle  and style the new filter forms

* overflow gradient

* use `cancel-circle` icon

* adjust logo sizing

* adjust filter type keys and overflow gradient

* restructure this.filterValue for multiple selections via input

* select and delete one

* load integration logo in Languages selections

* update pushstate and pull state

* switch checkbox evnt listener. cond render cancel circle

* rm content from master merge

* adjust filter logic. allow multiple select of a filter type

* update comments. fix deleteOneSelection

* comments and name changes

* selection-container overflow and mobile filter

* prevent default

* comment

* empty results message

* validate the `languages` url param

* reorder Severity by decending severity

* stop propogation on toggler outside click

* filter form id

* data-id selection-container

* close-light data-id

* ruleset description markdownify

* comment

* update rulesets with yaml

* used `severities` info from source.

* $watch 'filteredRulesets' to load empty res msg

* class name change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants