Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public-accessibility-logic.md for S3 #20306

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

christophetd
Copy link
Contributor

related to https://github.com/DataDog/dd-source/pull/55855

Note: bucket policy is a domain-specific term that we should keep (instead of bucket's policy)

@christophetd christophetd requested a review from a team as a code owner October 23, 2023 13:48
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar fix

@hestonhoffman
Copy link
Contributor

@christophetd Is this one good to merge?

@christophetd
Copy link
Contributor Author

christophetd commented Dec 11, 2023

Waiting for a last check from Daniel

@christophetd christophetd merged commit 195cccf into master Dec 11, 2023
13 checks passed
@christophetd christophetd deleted the christophetd/s3-bucket-rap branch December 11, 2023 22:12
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
* Update public-accessibility-logic.md for S3

* Update content/en/security/cloud_security_management/guide/public-accessibility-logic.md

Co-authored-by: Heston Hoffman <[email protected]>

* Update content/en/security/cloud_security_management/guide/public-accessibility-logic.md

Co-authored-by: Christophe Tafani-Dereeper <[email protected]>

---------

Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Daniel de Beer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants