Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istio tracing: remove table of version correspondence #20983

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

dgoffredo
Copy link
Contributor

What does this PR do? What is the motivation?

A recent correspondence with a customer over an issue with our Istio tracing integration brought to light that our documentation is outdated.

We have a project planned to rewrite our Istio tracing documentation entirely, but for now I think we can remove unnecessary out-of-date information.

This revision removes a table that related Istio's release version to the corresponding Datadog C++ tracing library release version. That correspondence is no longer relevant, the table was out of date, and the context about environment variables included a broken link.

Our support policy for Istio is "when a new Istio release comes out, we support it." I think it's best to leave that implicit, and avoid customers inferring it from a table about library versions.

@dgoffredo dgoffredo requested a review from a team as a code owner December 12, 2023 00:49
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@cswatt
Copy link
Contributor

cswatt commented Dec 12, 2023

I'm going to go ahead and merge this, as out-of-date information isn't of any use.

@cswatt cswatt merged commit 93d258e into master Dec 12, 2023
14 checks passed
@cswatt cswatt deleted the david.goffredo/update-istio-tracing-support-table branch December 12, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants