Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Database Monitoring] Update sqlserver setup documentation to mention log shipping #20989

Merged
merged 6 commits into from
Jan 4, 2024
Merged

[Database Monitoring] Update sqlserver setup documentation to mention log shipping #20989

merged 6 commits into from
Jan 4, 2024

Conversation

joelmarcotte
Copy link
Contributor

@joelmarcotte joelmarcotte commented Dec 12, 2023 •
edited
Loading

What does this PR do? What is the motivation?

  • Adds documentation about log shipping monitoring for the SQLServer integration, which will be available in agent 7.50+.

Merge instructions

  • Please merge after reviewing

Additional notes

@joelmarcotte joelmarcotte requested review from a team as code owners December 12, 2023 17:01
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@cswatt cswatt added the Do Not Merge Just do not merge this PR :) label Dec 12, 2023
cswatt
cswatt requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@cswatt cswatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions.

I'm also adding a do not merge label to this PR. Please let the documentation team know when this feature is available and we'll merge! Thanks!

content/en/database_monitoring/setup_sql_server/azure.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/azure.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/azure.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/rds.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/rds.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/selfhosted.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/selfhosted.md Outdated Show resolved Hide resolved
content/en/database_monitoring/setup_sql_server/selfhosted.md Outdated Show resolved Hide resolved
@joelmarcotte
Copy link
Contributor Author

The feature is now available @cswatt so this is good to merge.

@cswatt cswatt removed the Do Not Merge Just do not merge this PR :) label Jan 4, 2024
@cswatt cswatt merged commit bdb5b0a into master Jan 4, 2024
10 checks passed
@cswatt cswatt deleted the joel.marcotte/log-shipping-docs branch January 4, 2024 16:46
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
@joelmarcotte @cswatt @MaelNamNam
[Database Monitoring] Update sqlserver setup documentation to mention…
a60a24f 
… log shipping (#20989)

* [DBM] - Add documentation about monitoring log shipping in sqlserver

* azure

* Update content/en/database_monitoring/setup_sql_server/selfhosted.md

Co-authored-by: cecilia saixue watt <[email protected]>

* Update content/en/database_monitoring/setup_sql_server/azure.md

Co-authored-by: cecilia saixue watt <[email protected]>

* Apply suggestions from code review

Co-authored-by: cecilia saixue watt <[email protected]>

* empty push

---------

Co-authored-by: cecilia saixue watt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ynnadkrap ynnadkrap ynnadkrap approved these changes

@cswatt cswatt cswatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelmarcotte @cswatt @ynnadkrap