Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-6680] Add keyword dictionary and priority level #20991

Merged
merged 13 commits into from
Dec 23, 2023
Merged

[DOCS-6680] Add keyword dictionary and priority level #20991

merged 13 commits into from
Dec 23, 2023

Conversation

maycmlee
Copy link
Contributor

@maycmlee maycmlee commented Dec 12, 2023 •
edited
Loading

What does this PR do? What is the motivation?

Adds info on SDS keyword dictionary and priority level.
Moves the regex content to the custom rules section.
Move the OOTB section up.

DOCS-6680

Merge instructions

  • Please merge after reviewing

Additional notes

@maycmlee maycmlee added the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 12, 2023
@maycmlee maycmlee requested a review from a team as a code owner December 12, 2023 18:38
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2023 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@maycmlee maycmlee requested a review from toriteng December 12, 2023 19:13
maycmlee
maycmlee commented Dec 12, 2023
View reviewed changes
content/en/sensitive_data_scanner.md Outdated Show resolved Hide resolved
content/en/sensitive_data_scanner.md Outdated Show resolved Hide resolved
@maycmlee maycmlee removed the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 22, 2023
@maycmlee maycmlee removed the request for review from toriteng December 22, 2023 22:52
buraizu
buraizu approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall and approving; just posted a couple of extremely minor updates for consistency and a question about a part that wasn't clear to me.

content/en/sensitive_data_scanner.md Outdated Show resolved Hide resolved
content/en/sensitive_data_scanner.md Outdated Show resolved Hide resolved
@maycmlee maycmlee merged commit 992884a into master Dec 23, 2023
10 checks passed
@maycmlee maycmlee deleted the may/add-sds-keyword-dictionary branch December 23, 2023 00:31
MaelNamNam pushed a commit that referenced this pull request Jan 17, 2024
@maycmlee @buraizu @MaelNamNam
[DOCS-6680] Add keyword dictionary and priority level (#20991)
a45abdd 
* add keyword dictionary and priority level

* move location

* moveregex

* small edit

* move priority level

* Apply suggestions from code review

* Update sensitive_data_scanner.md

* apply suggestion on the other section

* Update sensitive_data_scanner.md

* add indent

* Apply suggestions from code review

Co-authored-by: Bryce Eadie <[email protected]>

---------

Co-authored-by: Victoria Teng <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraizu buraizu buraizu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maycmlee @buraizu