[DOCS-9557] adding storage monitoring doc #26377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
|
DOCS-9557 has been created for review |
buraizu
changed the title
buraizu
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Thanks for the PR! In addition to the edits requested:
- Image files are not rendering in their current location. They will need to be moved to
static/images/integrations/guide/storage_monitoring/. Note that thestorage_monitoringfolder will need to be created first - For the
cloud-inventory-policies-cfn.yamlinstructions, no information is provided for the Configure stack options screen. Is this intentional?
Please let me know if you have any feedback or questions!
Comment on lines
100
to
104
| 4. Configure the following settings: | ||
| - Set a configuration name | ||
| - (Optional) Specify a source bucket prefix | ||
| - We also advise picking “Current Versions Only” | ||
| - In select destination bucket, pick the newly created destination bucket. Example, if bucket is named destination-bucket `s3://your-destination-bucket` |
There was a problem hiding this comment.
Suggested change
| 4. Configure the following settings: | |
| - Set a configuration name | |
| - (Optional) Specify a source bucket prefix | |
| - We also advise picking “Current Versions Only” | |
| - In select destination bucket, pick the newly created destination bucket. Example, if bucket is named destination-bucket `s3://your-destination-bucket` | |
| 4. Configure the following settings: | |
| - Set a configuration name | |
| - (Optional) Specify a source bucket prefix | |
| - **Object versions**: Datadog recommends selecting **Current Versions Only** | |
| - **Destination**: Select the destination bucket. For example, if the bucket is named `destination-bucket`, enter `s3://your-destination-bucket` |
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
buraizu
previously requested changes
Nov 22, 2024
There was a problem hiding this comment.
This review:
- Fixes image addresses
- Moves links within tabs (each tab needs to contain its own set of links, apologies for my mistaken suggestions in the first review)
- Updates image widths to
90%, because currently the text on them is too small to read without expanding the image - Moves your email address out of the page and into the list of reference links, since our guidance on PII in public content requests that these not be added to the docs. With that said, could users just as well reach out on #storage-monitoring instead, as mentioned on line
127? If so, that would likely be the ideal approach.
Also, I'm guessing that it's intentional to not add a link to this page to the integration guides page, but let me know if that's incorrect
Co-authored-by: Bryce Eadie <[email protected]>
Co-authored-by: Bryce Eadie <[email protected]>
|
Thank you Bryce! Yes it's intentional that we've not added to the integration guides page because we will be sharing this as a "private" link to interested customers and this page shouldn't be visible in search or lists. |
urseberry
reviewed
Nov 22, 2024
| {{% /tab %}} | ||
| {{% tab "AWS Console" %}} | ||
|
|
||
| To manually set up the required [Amazon S3 Inventory][2] and related configuration, follow these steps: |
There was a problem hiding this comment.
The link to Amazon S3 Inventory is broken in the preview.
| 1. Go to the [Amazon S3 buckets page][203] in the AWS console, and select the bucket. | ||
| 2. Navigate to the bucket's **Management** tab. | ||
| 3. Click **Create inventory configuration**. | ||
| 4. Configure the following settings: |
There was a problem hiding this comment.
This formatting is broken in the preview. To make a nested list, each level of nesting needs to be indented by 4 spaces. Here it looks like you may have indented it only 2 sapces.
Co-authored-by: Ursula Chen <[email protected]>
urseberry
approved these changes
Nov 22, 2024
urseberry
dismissed
buraizu’s stale review
Taking over Documentation review because Bryce is on PTO.
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
mahashree.rajendran/storage-monitoring-private
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
theraffoul
pushed a commit
that referenced
this pull request
Nov 25, 2024
* adding storage monitoring doc * add images & frontmatter * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * addressing review comments * add cost call out * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * address review comments * add single destination bucket requirement * Apply suggestions from code review Co-authored-by: Ursula Chen <[email protected]> * addressing review * line break * line break * fixing formatting --------- Co-authored-by: Bryce Eadie <[email protected]> Co-authored-by: Ursula Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Add a new "private" setup guide for the Storage Monitoring product in Preview.
Merge instructions
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes