Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGENTLESS][SEC-17683] Add Azure onboarding to Agentless documentation #26786

Merged
merged 18 commits into from
Jan 2, 2025

Conversation

kacembouhmadi
Copy link
Contributor

@kacembouhmadi kacembouhmadi commented Dec 16, 2024

What does this PR do? What is the motivation?

This PR mainly document the support of Azure cloud provider in the K9 Agentless solution.
We tried to make most of the Agentless docs cloud-agnostic, although we might want to revisit the structure of the documentation later on.
Why does it matter?
We'll soon support Azure onboarding from the UI for existing subscriptions.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Dec 16, 2024
@kacembouhmadi kacembouhmadi marked this pull request as ready for review December 18, 2024 10:31
@kacembouhmadi kacembouhmadi requested a review from a team as a code owner December 18, 2024 10:31
@kacembouhmadi kacembouhmadi changed the title [AGENTLESS] Add Azure onboarding to Agentless documentation [AGENTLESS][SEC-17683] Add Azure onboarding to Agentless documentation Dec 18, 2024

1. On the [Cloud Security Management Setup][1] page, click **Cloud Integrations** > **Azure**.
1. Locate the tenant id of your subscription.
1. **[OPTIONAL]** you can enable **Resource Scanning** for the tenant to also enable misconfigurations detection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. **[OPTIONAL]** you can enable **Resource Scanning** for the tenant to also enable misconfigurations detection.

@rtrieu rtrieu added the editorial review Waiting on a more in-depth review label Dec 18, 2024
@drichards-87 drichards-87 self-requested a review December 19, 2024 22:42
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback from Docs.

Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some additional feedback.

Comment on lines 17 to 21
<div class="alert alert-info">This article provides instructions for the new user quick start workflow that uses AWS CloudFormation to set up Agentless Scanning.
For existing users who want to add a new AWS account or enable Agentless Scanning on an existing integrated AWS account, see the instructions for
<a href="/security/cloud_security_management/setup/agentless_scanning/terraform">Terraform</a>,
<a href="/security/cloud_security_management/setup/agentless_scanning/cloudformation">AWS CloudFormation</a>,
or <a href="/security/cloud_security_management/setup/agentless_scanning/azure_resource_manager">Azure Resource Manager</a>.</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a test org. and it looks like the quick start workflow is only available for AWS right now? If that's correct, then I think we should remove Azure Resource Manager from the note, or reword the note so that it's not specific to AWS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the quick start workflow is not available on Azure yet. I think the paragraph above is a generic paragraph we tried to reuse in most setup pages, but it can lead to some confusion indeed.

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 2, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-02 18:28:06 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-02 18:33:50 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 824dc0f into master Jan 2, 2025
18 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kacem.bouhmadi/agentless-doc-azure branch January 2, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants