Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for watchdog 3rd party monitoring #26918

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

HugoPct
Copy link
Contributor

@HugoPct HugoPct commented Dec 30, 2024

What does this PR do? What is the motivation?

add documentation for watchdog 3rd party monitoring, new feature that we are soon going to release.

Merge instructions

Below items to be tackled before the release of this docs (on me)

  • Roll out the feature
  • Roll out the blog post
  • Edit the blog post URL in the FURTHER READING section of this docs page
  • Get a legal review

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@HugoPct HugoPct requested a review from a team as a code owner December 30, 2024 14:54
@github-actions github-actions bot added the Images Images are added/removed with this PR label Dec 30, 2024
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

@aliciascott
Copy link
Contributor

aliciascott commented Dec 30, 2024

Hi @HugoPct general comment on this before we start the review:

  1. Is this a new doc/different from the Faulty Detection here? https://docs.datadoghq.com/watchdog/faulty_deployment_detection/
  2. If so it should also probably be added to the menu file.
  3. The Further Reading isn't showing up in the staging preview, because of this incorrectly formatted URL "https://www.datadoghq.com/blog/<URL FROM THE BLOGPOST>/". We do have a process to add blog posts to docs pages after they are published so you can remove this section from further reading for now.

Let us know on the above once you get this added to the menu/left Nav, etc and then we can start a review, thanks!
I've added a Work in Progress label for now but it can be removed once it's ready for review.

@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 30, 2024
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Dec 31, 2024
@HugoPct
Copy link
Contributor Author

HugoPct commented Dec 31, 2024

Hi @aliciascott
1.2. ok added to the menu file
3. done

@HugoPct HugoPct removed the WORK IN PROGRESS No review needed, it's a wip ;) label Dec 31, 2024
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some suggestions! Let me know if you have any questions.

content/en/watchdog/faulty_cloud_saas_api_detection.md Outdated Show resolved Hide resolved
content/en/watchdog/faulty_cloud_saas_api_detection.md Outdated Show resolved Hide resolved
content/en/watchdog/faulty_cloud_saas_api_detection.md Outdated Show resolved Hide resolved
content/en/watchdog/faulty_cloud_saas_api_detection.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants