Skip to content

Commit

Permalink
ci: fix success job (#494)
Browse files Browse the repository at this point in the history
GitHub considers skipped jobs as fulfilling requirements when merging
pull requests. We need to ensure that the success job fails if any
previous job has failed.
  • Loading branch information
CBenoit authored Jul 16, 2024
1 parent 2e1a9ac commit abc0ee0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ jobs:
success:
name: Success
runs-on: ubuntu-latest
if: ${{ success() }}
if: ${{ always() }}
needs:
- formatting
- typos
Expand All @@ -182,4 +182,10 @@ jobs:

steps:
- name: CI succeeded
id: succeeded
if: ${{ !contains(needs.*.result, 'failure') }}
run: exit 0

- name: CI failed
if: ${{ steps.succeeded.outcome == 'skipped' }}
run: exit 1
2 changes: 1 addition & 1 deletion crates/ironrdp-client/src/rdp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ async fn active_session(
}
}

info!(width, height, "resize event");
trace!(width, height, "Resize event");
let (width, height) = MonitorLayoutEntry::adjust_display_size(width.into(), height.into());
debug!(width, height, "Adjusted display size");

Expand Down

0 comments on commit abc0ee0

Please sign in to comment.