Don't run wmic multiple times

DigitalRuby · Apr 16, 2020 · a7a085a · a7a085a
1 parent 13859d9
commit a7a085a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/IPBanCore/Core/Utility/OSUtility.cs b/IPBanCore/Core/Utility/OSUtility.cs
@@ -154,12 +154,14 @@ private static void LoadVersionFromWmic()
 
             Logger.Info("Attempting to load os info from wmic");
 
+            // attempt to run wmic to generate the info we want
+            StartProcessAndWait(5000, "cmd", "/C wmic path Win32_OperatingSystem get Caption,Version /format:table > \"" + tempFile + "\"");
+
             // try up to 10 times to read the file
             for (int i = 0; i < 10; i++)
             {
                 try
                 {
-                    StartProcessAndWait(5000, "cmd", "/C wmic path Win32_OperatingSystem get Caption,Version /format:table > \"" + tempFile + "\"");
                     string[] lines = File.ReadAllLines(tempFile);
                     ExtensionMethods.FileDeleteWithRetry(tempFile);
                     if (lines.Length > 1)