Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entities not rendering when Identity menu is opened #512

Open
wants to merge 1 commit into
base: arch-1.19
Choose a base branch
from

Conversation

SistrScarlet
Copy link

私が制作しているMod、LittleMaidModelLoaderを導入時に発生するバグを修正しました。
Identity menuを開くと、その後にすべてのエンティティがレンダリングされなくなる不具合を修正しました。

変更内容を大まかに説明しますと、InventoryScreen.drawEntity()の実行時に例外が投げられた場合、catch内で後処理を実行するように変更しました。

InventoryScreen.drawEntity()の処理内容は前処理、描画処理、後処理の三つに分かれています。
しかし、描画処理で例外が発生した後、後処理が実行されないことで不具合が発生していました。
そのため、catch内で後処理を実行することで不具合を回避しています。

Forge/Fabricの両環境でテストしました。

Fixed a bug that occurred when installing LittleMaidModelLoader, a mod I am working on.
Fixed a bug where opening the Identity menu would not render all entities afterwards.

Roughly speaking, if an exception is thrown when executing InventoryScreen.drawEntity(), the post-processing is now performed in catch.

The processing content of InventoryScreen.drawEntity() is divided into three parts: pre-processing, drawing, and post-processing.
However, after an exception occurred during the drawing process, the post-processing was not executed, causing a problem.
Therefore, the post-processing is executed in the "catch" to avoid the problem.

Tested on both Forge and Fabric environments.

Translated with www.DeepL.com/Translator (free version)

@SistrScarlet
Copy link
Author

よく確認してみたところ、私のModの方を更新することで、このプルリクエストの更新が無くともバグが発生しなくなりました。
ただ、他のModのモブに対して、同様の不具合が発生した場合の対策にはなると思います。

I checked carefully and by updating my mod's side, the bug no longer occurs even without this pull request update.
However, it would be a good countermeasure in case the same bug occurs for other mods' mobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant