Small fix within the UserService and UpdateLastSeen unit tests added

DustSwiffer · Jul 23, 2024 · c371eb9 · c371eb9
1 parent fb4ad70
commit c371eb9
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 2 deletions.
diff --git a/AdvancedAPI.Business/Services/UserService.cs b/AdvancedAPI.Business/Services/UserService.cs
@@ -54,8 +54,7 @@ public UserService(
     /// <inheritdoc />
     public async Task UpdateLastSeen(string userId)
     {
-        IEnumerable<LastSeen> lastSeens = await _lastSeenRepository.FindAsync(e => e.UserId == userId);
-        LastSeen? lastSeen = lastSeens.FirstOrDefault();
+        LastSeen? lastSeen = await _lastSeenRepository.GetByUserId(userId);
 
         if (lastSeen != null)
         {

diff --git a/AdvancedAPI.Tests/Services/UserServiceTests.cs b/AdvancedAPI.Tests/Services/UserServiceTests.cs
@@ -127,4 +127,60 @@ public async Task GetUserProfileReturnsSuccessfullyWithFilledLastSeen()
 
         Assert.Equal(lastSeenResult.DateTime.ToString(CultureInfo.InvariantCulture), response.LastSeen);
     }
+
+    /// <summary>
+    /// Tests if UpdateLastSeen calls the AddAsync of the LastSeen Repo just once.
+    /// </summary>
+    [Fact]
+    public async Task UpdateLastSeenCreatesNew()
+    {
+        string userId = "valid-user-id";
+        _lastSeenRepository.Setup(lsr => lsr.GetByUserId(It.IsAny<string>())).ReturnsAsync((LastSeen?)null);
+
+        await _UserService.UpdateLastSeen(userId);
+
+        _lastSeenRepository.Verify(lsr => lsr.AddAsync(It.IsAny<LastSeen>()), Times.Once);
+    }
+
+    /// <summary>
+    /// Tests if UpdateLastSeen calls the Update of the LastSeen Repo just once.
+    /// </summary>
+    [Fact]
+    public async Task UpdateLastSeenUpdates()
+    {
+        string userId = "valid-user-id";
+        LastSeen lastSeenResult = new LastSeen
+        {
+            Id = 1,
+            UserId = userId,
+            DateTime = DateTime.Now,
+        };
+
+        _lastSeenRepository.Setup(lsr => lsr.GetByUserId(It.IsAny<string>())).ReturnsAsync(lastSeenResult);
+
+        await _UserService.UpdateLastSeen(userId);
+
+        _lastSeenRepository.Verify(lsr => lsr.Update(It.IsAny<LastSeen>()), Times.Once);
+    }
+
+    /// <summary>
+    /// Tests if UpdateLastSeen calls the Saves the database changes.
+    /// </summary>
+    [Fact]
+    public async Task UpdateLastSeenSaves()
+    {
+        string userId = "valid-user-id";
+        LastSeen lastSeenResult = new LastSeen
+        {
+            Id = 1,
+            UserId = userId,
+            DateTime = DateTime.Now,
+        };
+
+        _lastSeenRepository.Setup(lsr => lsr.GetByUserId(It.IsAny<string>())).ReturnsAsync(lastSeenResult);
+
+        await _UserService.UpdateLastSeen(userId);
+
+        _lastSeenRepository.Verify(lsr => lsr.SaveAsync(), Times.Once);
+    }
 }