testmempoolaccept: feed genesis hash into sighash computation #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
approved these changes
May 5, 2023
delta1
added a commit
to delta1/elements
that referenced
this pull request
Jul 3, 2023
bitcoin/bitcoin#23381 refactored PolicyScriptChecks to store the precomputed txdata in the workspace, so I have added the genesis hash to the transform of the workspaces in AcceptMultipleTransactions. I don't think there was a specific test for this, so during review it may be worth checking this thoroughly. We also need a test to cover this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot test this because of #1238 and #1237 as well as the lack of functionality in the PSBT RPCs, inability to inform the wallet about a UTXO without broadcasting the transaction it comes from, etc etc.