-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read helpers #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Nov 1, 2022
MarijnS95
reviewed
Nov 1, 2022
MarijnS95
reviewed
Nov 1, 2022
MarijnS95
reviewed
Nov 1, 2022
MarijnS95
reviewed
Nov 1, 2022
Thanks for the review @MarijnS95 , though, FWIW all your comments are in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by Traverse-Research/gpu-allocator#139, scaffolded some read-helper functions.
These helpers are mostly all unsafe and have both semi-checked and completely unchecked variants. They are relevant in either case because they lay out in documentation exactly what the needed safety requirements are to read the given data, given that we have a properly implemented
Slab
, and try to remove some common footguns (alignment, size within allocation) where possible in the checked variants.A note for reviewers is that you can skip the
copy.rs
file as that is just code movement from the oldlib.rs
.@eddyb, requested your review since you helped validate
presser
originally and you might have some valuable input on the safety comments/requirements here.