Update copyright headers #459
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 89.04% 89.09% +0.04%
==========================================
Files 137 137
Lines 4820 4842 +22
Branches 547 547
==========================================
+ Hits 4292 4314 +22
Misses 403 403
Partials 125 125 ☔ View full report in Codecov by Sentry. |
|
There may be a compatibility problem with pytest and pytest-lazy-fixtures TvoroG/pytest-lazy-fixture#65 which fails some tests. |
There was a problem hiding this comment.
This looks very good! I found only one inconsistency, see below. I am also very happy to look into the tests problem and have it fixed. Thanks, @mmahsereci !
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| # Copyright 2024 The Emukit Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
That's nice to see! The script certainly worked well here, as this file dates to 2022. So it was given incorrect header when created, and script handled this fine. Great!
setup.py
Outdated
| # Copyright 2024 The Emukit Authors. All Rights Reserved. | ||
| # | ||
| # Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. |
There was a problem hiding this comment.
That's interesting! In most files the headers carry licence identifier, but sometimes, like here, they don't. Do you know why?
There was a problem hiding this comment.
There are 3 files or so that had different headers with an extended license mention (It may not be visible in the diff). This file (setup.py) is one of them. Here is the unchanged file for comparison. Can you have a look at the original and updated version and comment on how you think we should handle these `special' files?
There was a problem hiding this comment.
I'd say let's make all headers look the same, so that there are no special files going forward
There was a problem hiding this comment.
OK, I'll change those to match the other headers.
I just saw that some of the non-py files have no headers (e.g., pyproject.toml) shall I add headers to those as well? Also can you have a look at the NOTICE file? I just added one line there.
|
I changed the years to year ranges in the copyright statements @apaleyes . As mentioned offline, I am merging this for now. |
Issue #, if available:
Description of changes:
Test PR to see how headers are looking like.
@apaleyes I can change the text as needed. This is just to see if things work. All files before "2020-10-26" should have two copyright notices in the header and the ones created after only one.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.