fix(date-picker): fix year-select width logic #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
no changelog entry
anveshmekala
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
🥇
Tested & works as expected.
Browser might have fixed the font object issue of returning empty string. Discussed with @jcfranco regarding this and there will be a followup spike.
jcfranco
deleted the
jcfranco/fix-date-picker-month-header-width-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
Fixes a text width logic issue where
fontwould be empty instead of the expected shorthand value.This also moves the text-width calculation logic to a
requestAnimationFramecallback to improve timing and performance.BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE