Implementation of CommandFilters, replacing cooldowns and costs #4224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split the provider up for both spigot/paper impl.
# Conflicts: # providers/PaperProvider/build.gradle
# Conflicts: # providers/PaperProvider/build.gradle
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java
Removing PaperReflFormattedCommandAliasProvider.java and the need for the reflection library in paper providers.
…ndAliasProvider an interface
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/Essentials.java # Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java # Essentials/src/main/java/com/earth2me/essentials/IEssentials.java
|
github is showing no files changed for some reason |
|
Could it also include command confirmations? IIRC, right now there are two commands that you can confirm: Also, is the config for this moved to a new file? It would be nice if it was, the Essentials' config is soooo looong. |
|
hm yeah, seems this was already merged lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically implements #3200, with just a small difference in yaml format: made the
namerequired, as a key, just like kits.Automatic converter is included, and will create the new yaml format from existing nodes.
Formats for
commandwill be the same as with thecommand-costs, formats forpatternwill be the same as incommand-cooldowns.Closes #3200, #3847