Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-08-14] Update App to React native 0.72 version #18444

Closed
mountiny opened this issue May 4, 2023 · 27 comments
Closed

[HOLD for payment 2023-08-14] Update App to React native 0.72 version #18444

mountiny opened this issue May 4, 2023 · 27 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented May 4, 2023

Let's stay up to date with the latest React native version for the best performance and features available and update our RN version to 0.72

Previous internal issue https://github.com/Expensify/Expensify/issues/275274

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels May 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 4, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 4, 2023
@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert contributor group - I would like to work on this issue

@fabioh8010
Copy link
Contributor

PR is ready: #18507

@mountiny
Copy link
Contributor Author

Being hyper focused on the EC3 committment so unable to help out here much, hopefully we can get more time on this next week

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@melvin-bot melvin-bot bot added the Overdue label May 23, 2023
@michaelhaxhiu
Copy link
Contributor

New Feature isn't as pressing as Bug. But we'll get this done soon ⏲️ 🧇

@melvin-bot melvin-bot bot removed the Overdue label May 23, 2023
@mountiny
Copy link
Contributor Author

This is being actively worked on in this PR #18507 hopefully we will get there soon

@melvin-bot melvin-bot bot added the Overdue label Jun 1, 2023
@mountiny
Copy link
Contributor Author

mountiny commented Jun 1, 2023

@fabioh8010 continues working on this

@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 12, 2023
@mountiny
Copy link
Contributor Author

Not overdue we changed strategy

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 22, 2023
@mountiny
Copy link
Contributor Author

@fabioh8010 is focusing on this 100% now, there is a stable release 🎉

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 3, 2023
@michaelhaxhiu
Copy link
Contributor

Note: I'm preparing to go OOO for ~2 weeks. @MitchExpensify can I ask you for a favor to ensure payment is handled properly.

I am not sure how this will get compensated because the PR #18507 has numerous C+ assigned but I think @mountiny has a clear sense of that piece!

@mountiny
Copy link
Contributor Author

mountiny commented Aug 6, 2023

I believe its @aimane-chnaif and @parasharrajat being paid $1000 for this PR great job!

agency C+ are paid differently.

@MitchExpensify
Copy link
Contributor

Thanks! And just to be sure @vitHoracek, is it ok to send the payment now and close this out?

@roryabraham
Copy link
Contributor

Yes we can close this out. We'll have another follow-up soon, but that's separate

@MitchExpensify
Copy link
Contributor

Thanks @roryabraham ! Offer sent here for payment before closure cc @parasharrajat @aimane-chnaif

@MitchExpensify
Copy link
Contributor

Paid @aimane-chnaif!

@parasharrajat Have you made the NewDot request for $1000?

@suraj-mandal
Copy link

Hi! I found this issue while going through the job description on upwork. Is this issue still existing? If yes, I would like to work on this

@melvin-bot
Copy link

melvin-bot bot commented Aug 9, 2023

📣 @suraj-mandal! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@parasharrajat
Copy link
Member

Payment requested.

@puneetlath puneetlath changed the title Update App to React native 0.72 version [HOLD for payment 2023-08-14] Update App to React native 0.72 version Aug 11, 2023
@puneetlath
Copy link
Contributor

The automation didn't work for some reason. Added hold for payment to the title.

@mountiny mountiny added Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 and removed Weekly KSv2 Reviewing Has a PR in review labels Aug 15, 2023
@JmillsExpensify
Copy link

@MitchExpensify In the future can you summarize payment in one post? I'll accept the above since multiple people confirmed the amount.

@JmillsExpensify
Copy link

Reviewed the details for @parasharrajat. Approved by payment in NewDot based on the $1,000 BZ summary above.

@MitchExpensify
Copy link
Contributor

@MitchExpensify In the future can you summarize payment in one post?

For sure!

@MitchExpensify
Copy link
Contributor

Closing as we're all paid out here and no BZ steps necessary

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants