-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor buildOptimisticTransaction function #54491
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Eslint error isn't related to our changes. |
@mkzie2 You need to fix the error even if it is not related to PR. |
@shubham1206agra Fixed. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-12-28.at.10.23.04.PM.movAndroid: mWeb ChromeScreen.Recording.2024-12-28.at.8.37.48.PM.moviOS: NativeScreen.Recording.2024-12-28.at.10.06.24.PM.moviOS: mWeb SafariScreen.Recording.2024-12-28.at.8.30.35.PM.movMacOS: Chrome / SafariScreen.Recording.2024-12-28.at.8.28.36.PM.movMacOS: DesktopScreen.Recording.2024-12-28.at.9.48.06.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good, but I would like to move a few fields
src/libs/TransactionUtils/index.ts
Outdated
}; | ||
|
||
type BuildOptimisticTransactionParams = { | ||
source?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you think source and filename should be part of the transactionParams? They relate to the transaction specifically so I would like to move them there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neil-marcellini I updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go thanks
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.80-1 🚀
|
Explanation of Change
Refactor buildOptimisticTransaction function
Fixed Issues
$ #54464
PROPOSAL: #54464 (comment)
Tests
Offline tests
Same
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-12-24.at.11.24.18.mov
Android: mWeb Chrome
Screen.Recording.2024-12-24.at.11.19.43.mov
iOS: Native
Screen.Recording.2024-12-24.at.11.26.14.mov
iOS: mWeb Safari
Screen.Recording.2024-12-24.at.11.21.57.mov
MacOS: Chrome / Safari
Screen.Recording.2024-12-24.at.11.17.32.mov
MacOS: Desktop
Screen.Recording.2024-12-24.at.11.28.44.mov