Fix warnings

FigBug · Nov 8, 2023 · 0ca1a29 · 0ca1a29
1 parent b9c59ea
commit 0ca1a29
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/modules/gin_dsp/dsp/gin_platereverb.h b/modules/gin_dsp/dsp/gin_platereverb.h
@@ -169,8 +169,8 @@ template <class F, class I> class PlateReverb
         // Scale the taps
         for (I i = 0; i < kNumTaps; i++)
         {
-            leftTaps[i] = baseLeftTaps[i] * sizeRatio;
-            rightTaps[i] = baseRightTaps[i] * sizeRatio;
+            leftTaps[size_t (i)] = baseLeftTaps[size_t (i)] * sizeRatio;
+            rightTaps[size_t (i)] = baseRightTaps[size_t (i)] * sizeRatio;
         }
     }
 
@@ -316,8 +316,8 @@ template <class F, class I> class PlateReverb
 
             // For speed, create a bigger buffer than we really need.
             I bufferSize = ceilPowerOfTwo (size);
-            buffer.reset (new F[bufferSize]);
-            std::memset (buffer.get(), 0, bufferSize * sizeof(F));
+            buffer.reset (new F[size_t (bufferSize)]);
+            std::memset (buffer.get(), 0, size_t (bufferSize) * sizeof(F));
 
             mask = bufferSize - 1;
 
@@ -328,7 +328,7 @@ template <class F, class I> class PlateReverb
 
         inline void push(F val)
         {
-            buffer[writeIdx++] = val;
+            buffer[size_t (writeIdx++)] = val;
             writeIdx &= mask;
         }
 
@@ -342,8 +342,8 @@ template <class F, class I> class PlateReverb
             F frac = 1 - (delay - d);
 
             I readIdx = (writeIdx - 1) - d;
-            F a = buffer[(readIdx - 1) & mask];
-            F b = buffer[readIdx & mask];
+            F a = buffer[size_t ((readIdx - 1) & mask)];
+            F b = buffer[size_t (readIdx & mask)];
 
             return a + (b - a) * frac;
         }
@@ -358,7 +358,7 @@ template <class F, class I> class PlateReverb
 
         void reset()
         {
-            std::memset (buffer.get(), 0, ceilPowerOfTwo (size) * sizeof (F));
+            std::memset (buffer.get(), 0, size_t (ceilPowerOfTwo (size)) * sizeof (F));
             writeIdx = 0;
         }
 

diff --git a/modules/gin_plugin/components/gin_scaledplugineditor.h b/modules/gin_plugin/components/gin_scaledplugineditor.h
@@ -34,6 +34,7 @@ class ScaledPluginEditor : public juce::AudioProcessorEditor
 
     ~ScaledPluginEditor() override
     {
+        processor.editorBeingDeleted (this);
         setLookAndFeel (nullptr);
     }
 

diff --git a/modules/gin_simd/gin_simd.h b/modules/gin_simd/gin_simd.h
@@ -56,16 +56,14 @@
 
 #include <juce_core/juce_core.h>
 
-namespace gin
-{
-
 JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE("-Wimplicit-float-conversion",
                                     "-Wunused-parameter",
                                     "-Wshadow",
                                     "-Wzero-length-array",
                                     "-Wcast-align",
                                     "-Wimplicit-int-conversion",
-                                    "-Warray-parameter")
+                                    "-Warray-parameter",
+                                    "-Wsign-conversion")
 
 #if JUCE_INTEL
  #ifndef __SSE__
@@ -80,5 +78,7 @@ JUCE_BEGIN_IGNORE_WARNINGS_GCC_LIKE("-Wimplicit-float-conversion",
 
 JUCE_END_IGNORE_WARNINGS_GCC_LIKE
 
+namespace gin
+{
 #include "math/gin_math.h"
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,6 +34,7 @@ class ScaledPluginEditor : public juce::AudioProcessorEditor @@
         ~ScaledPluginEditor() override
         {
+            processor.editorBeingDeleted (this);
             setLookAndFeel (nullptr);
         }
@@ Expand Down @@