Luko/offer req card user profile #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianoschillagi
requested review from
ethanswift,
OnyekachiSamuel and
stavares843
as code owners
|
|
ethanswift
suggested changes
Jun 16, 2020
Comment on lines
36
to
48
| init(initials: String, name: String, location: String) { | ||
| super.init(frame: .zero) | ||
|
|
||
| // User Initials | ||
| let userInitialsSize = CGSize(width: 100, height: 500) | ||
| userInitials.frame.size = userInitialsSize | ||
| userInitials.layer.cornerRadius = frame.size.height / 2 | ||
| userInitials.text = initials | ||
| userInitials.textAlignment = .center | ||
| userInitials.backgroundColor = .fightPandemicsGhostWhite() | ||
| userInitials.layer.borderWidth = 1 | ||
| userInitials.layer.borderColor = UIColor.fightPandemicsNeonBlue().cgColor | ||
| userInitials.translatesAutoresizingMaskIntoConstraints = false |
There was a problem hiding this comment.
this also takes the user image, if it has an image, otherwise it takes initials.
also its circle which you can make by giving a corner radius of half the height of the frame.
There was a problem hiding this comment.
Ok @ethanswift . I need your help on this, please. Tomorrow I will contact you...
Thanks!
There was a problem hiding this comment.
Ok. I added the View Button but It need layout configuration yet.
Comment on lines
36
to
40
| title.frame = CGRect(x: 0, y: 400, width: 200, height: 200) | ||
| title.attributedText = NSAttributedString(string: tit, | ||
| attributes: [NSAttributedString.Key.font: Fonts.poppinsBold.customFont(size: 22), NSAttributedString.Key.foregroundColor: UIColor.fightPandemicsNero()]) | ||
| title.widthAnchor.constraint(equalToConstant: title.frame.width).isActive = true | ||
| title.heightAnchor.constraint(equalToConstant: 50.0).isActive = true |
There was a problem hiding this comment.
title shouldn't get wrapped, its number of lines should be zero.
There was a problem hiding this comment.
I think that this is solved (see screenshot pls)
|
last update - thursday 18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Creates a Offers Requests User Card
Checklist
Which issue(s) this PR fixes:
Resolves #171 #172 #173
Special notes for reviewers:
The task is 75% done. I need help in order to resolve some layout-constraints issues.
Additional comments:
Maybe on this week we can finish it, come on!