Delete visibleContent check to remove get-pixels dependency to resolve security advisory #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelcarr
force-pushed
the
remove-get-pixels-dep
branch
from
52f784a to
9e6edd5
Compare
joelcarr
force-pushed
the
remove-get-pixels-dep
branch
from
9e6edd5 to
d4e08bb
Compare
ivomurrell
approved these changes
Jan 2, 2025
When migration Financial-Times/next-preflight#723 to Tool Kit, the snyk check failed as the `get-pixels` dependency of `n-test` has a couple of security advisories open (see link below). Unfortunately the get-pixels dependency has not been updated in a couple of years and show no sign of resolving this issue. https://app.snyk.io/org/customer-products/project/4d2f1c5e-1868-477b-afcf-70879ce6b2d9/pr-check/7ee89281-dbc5-4879-801e-80432000340d This dependency is only for the `visibleContent` check which isn't configured in any repository in the Financial-Times org: https://github.com/search?q=org%3AFinancial-Times%20visibleContent&type=code Therefore we can remove this functionality. I spoke with Arjun to double check and he informed me that this was an experimental feature that never took off which can be removed.
joelcarr
force-pushed
the
remove-get-pixels-dep
branch
from
d4e08bb to
2a0c6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migration Financial-Times/next-preflight#723 to Tool Kit, the snyk check failed as the
get-pixelsdependency ofn-testhas a couple of security advisories open (see link below). Unfortunately the get-pixels dependency has not been updated in a couple of years and show no sign of resolving this issue.https://app.snyk.io/org/customer-products/project/4d2f1c5e-1868-477b-afcf-70879ce6b2d9/pr-check/7ee89281-dbc5-4879-801e-80432000340d
This dependency is only for the
visibleContentcheck which isn't configured in any repository in the Financial-Times org:https://github.com/search?q=org%3AFinancial-Times%20visibleContent&type=code
Therefore we can remove this functionality. I spoke with Arjun to double check and he informed me that this was an experimental feature that never took off which can be removed.