Use Convert.ToHexString.

FirebirdSQL · Jan 8, 2025 · 59cfb1f · 59cfb1f
1 parent 9bc4e30
commit 59cfb1f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/FirebirdSql.Data.FirebirdClient.Tests/FbDataReaderTests.cs b/src/FirebirdSql.Data.FirebirdClient.Tests/FbDataReaderTests.cs
@@ -313,7 +313,7 @@ public async Task ReadBinaryTest()
 			{
 				bytes[i] = (byte)random.Next(byte.MinValue, byte.MaxValue);
 			}
-			var binaryString = $"x'{BitConverter.ToString(bytes).Replace("-", string.Empty)}'";
+			var binaryString = $"x'{Convert.ToHexString(bytes)}'";
 
 			await using (var command = new FbCommand($"select {binaryString} from TEST", Connection, transaction))
 			{

diff --git a/src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs b/src/FirebirdSql.Data.FirebirdClient/Common/Extensions.cs
@@ -48,7 +48,11 @@ public static IntPtr ReadIntPtr(this BinaryReader self)
 
 	public static string ToHexString(this byte[] b)
 	{
+#if NET5_0_OR_GREATER
+		return Convert.ToHexString(b);
+#else
 		return BitConverter.ToString(b).Replace("-", string.Empty);
+#endif
 	}
 
 	public static IEnumerable<IEnumerable<T>> Split<T>(this T[] array, int size)