Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/first page position of vertical string books, App can't open multibytes title book #217

Open
wants to merge 2 commits into
base: feature/horizontal_scroll
Choose a base branch
from

Conversation

garakutanokiseki
Copy link

I'm fix following 2 issue.

#1 App can't open some multibytes string title epub files.
#2 At opening book, Vertical string books (ex. Japanese books) always show a end of page but not first page.

@hrishikesh-kadam
Copy link
Contributor

@garakutanokiseki I have merged your branch in codetoart:fix/first-page-position-of-vertical-string

  1. Multibyte string issue - Can you please give us some text for which you did this fix or the book itself? We want to retain the original file name of the book. Also currently your code doesn't work for RAW source type.

  2. Vertical string issue - The code in which you made changes for this fix has been already deleted in v0.4.0. Can you explain us in detail what exactly you want to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants