Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes default options for Neovide to spec #144

Closed
wants to merge 0 commits into from

Conversation

ekorchmar
Copy link
Contributor

@ekorchmar ekorchmar commented Jan 18, 2024

Adresses issue #143

Description

Single commit, changing --nofork to --no-fork

Changes

Checklist

  • I have rebased my branch so that it has no conflicts
  • I have added tests where appropriate
  • Commit messages are compliant with Conventional Commits

Is this a breaking change?

No, fixes existing problem without affecting other modules behavior

Test results

  • OS: Linux
  • Thunderbird version: 115
    Tested manually to observe expected behavior -- the editor can start.

@Frederick888
Copy link
Owner

Conventional commits please. Something like

fix(ext): Update default Neovide argument to --no-fork

[1] https://github.com/neovide/neovide/commit/5743356d654dbeaf213c0da3e2988c4d89c218e1#diff-4583b895d17596f30dcbac33a7d47de9c210df2c07210bb0775b7c27097345daR55

@Frederick888
Copy link
Owner

Huh? Sorry I didn't want to close this. What happened...?

@Frederick888
Copy link
Owner

Frederick888 commented Jan 18, 2024

Oh... One of my git subcommands didn't play well with gh's checkout style (no remote, branch config only).

I just merged it manually and pushed. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants