Add support for env variables & add example docker stack #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I was unfortunately pulled away for work over the past entire month, I am taking a look now. |
RadioAndrea
reviewed
May 27, 2024
There was a problem hiding this comment.
Indeed XD, in which final form would you like to have it ?
There was a problem hiding this comment.
Ideally we can have it in user readable format.
If we end up needed it to be minimized, we can add a minimizer to the production release pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Hi,
Similar to the FreeTAKTeam/UI docker rework pull request here could be the beginning of such a docker revamp for the
FreeTAKHub-Webmap.I've updated the node-red flow to also support ENV variables, added a Dockerfile to build it and an example of a docker-compose usage.
The goal of this change would be to have a docker-compose stack able to start and configure FreeTAKTeam/UI, FreeTAKTeam/FreeTakServer and the FreeTAKTeam/FreeTAKHub-Webmap in a convenient way.
Let me know how you feel about it 🖖