Validation Name and Property Tuple Extend #372

fschrader1992 · 2020-03-26T17:01:34Z

This PR

fixes the exception when trying to append or extend a property with dtype tuple. Closes [Property] Exception on x-tuple Property extend or append #364
adds a validation for easy to read property and section names, if they were assigned as id. Closes [Validation] Check for readable odml object name content #365
changes the way of location and file used by test_fileio.py as it might not be found in local tests otherwise.
adds tests for validation errors on section or property init as asked for in Expand validator tests #369
fixes smaller issues with tests and pylint.

…heck

For Section and Property.

For xml, json and yaml.

Change to more robust way to access file location and use file from within test dir. Otherwise might not be found during local testing.

Because dtype always inferred as string.

coveralls · 2020-03-26T17:29:49Z

Coverage increased (+0.07%) to 75.694% when pulling 1d8e055 on fschrader1992:validation into 7e9299e on G-Node:master.

fschrader1992 · 2020-03-26T18:43:58Z

Checks for Code Quality:

Pylint
Rebase onto GNODE Master
Repeat Local Tests Python3.8
Repeat Local Tests Python2.7

mpsonntag

Very nice PR, thanks a lot!

Good catch with the append usage in the Property.extend tests!

mpsonntag · 2020-03-29T19:47:15Z

odml/validation.py

+    :param obj: odml.Section or odml.Property.
+    """
+    if obj.name == obj.id:
+        yield ValidationError(obj, 'Name should be readable', LABEL_WARNING)


Update the message to "Name should be human readable" to make it clearer whats expected of the user; but we can change this at a later point in time.

fschrader1992 added 16 commits March 26, 2020 17:52

[validation.py] Fix Wrong Error Message Variables Order for hasattr C…

56e12fe

…heck

[validation.py] Add Object Name Readability Check

aaac777

For Section and Property.

[test_validation.py] Add Test for Section Name Readability

13a51c8

[test_validation.py] Add Test for Property Name Readability

206b274

[test_validation.py] Fix Bad Continuation and Whitespace

6951184

[test_validation.py] Change Error Assertion for Load Section Tests

d3faa1f

For xml, json and yaml.

[test_validation.py] Add Test for Section Init Validation Stdout

89a5536

[test_validation.py] Replace For Loop by Filter

8a58ce1

[test_fileio.py] Change Test File Path to example.odml

cd5084a

Change to more robust way to access file location and use file from within test dir. Otherwise might not be found during local testing.

[property.py] Fix Tuple Extend Error

957dcda

Because dtype always inferred as string.

[property.py] Fix Tuple Append Error

543dcd4

Because dtype always inferred as string.

[test_property.py] Add Tuple Extend Test

132bcd1

[test_property.py] Add Tuple Append Test

e468a1f

[test_property.py] Fix Whitespace

a11fda9

[test_property.py] Fix Bad Line Continuation

b902a51

[test_property.py] Replace Append in Extend Test

1d8e055

mpsonntag approved these changes Mar 29, 2020

View reviewed changes

mpsonntag merged commit d9d5223 into G-Node:master Mar 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validation Name and Property Tuple Extend #372

Validation Name and Property Tuple Extend #372

fschrader1992 commented Mar 26, 2020

coveralls commented Mar 26, 2020

fschrader1992 commented Mar 26, 2020

mpsonntag left a comment

mpsonntag Mar 29, 2020

Validation Name and Property Tuple Extend #372

Validation Name and Property Tuple Extend #372

Conversation

fschrader1992 commented Mar 26, 2020

coveralls commented Mar 26, 2020

fschrader1992 commented Mar 26, 2020

mpsonntag left a comment

Choose a reason for hiding this comment

mpsonntag Mar 29, 2020

Choose a reason for hiding this comment