Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark mode, changed layout, updated upload file btn,fix the issss #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sahilsaif12
Copy link

@sahilsaif12 sahilsaif12 commented Oct 2, 2021

…e until you upload your photo you can't see download option

Description

• Added dark mode
• changed the layout little bit
• Redesign the upload file btn
• fix the issue that until you didn't upload your photo you don't get download option

Fixes #(issue number)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Have you tested your changes

i have tested all changes

Screenshot (if applicable)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

…e until you upload your photo you can't see download option
@sahilsaif12 sahilsaif12 closed this Oct 2, 2021
@sahilsaif12 sahilsaif12 reopened this Oct 2, 2021
Copy link
Member

@errorinc0de errorinc0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the UI a bit?
@DeagleOfficial do you want to add something?

@sahilsaif12
Copy link
Author

explain me little how the ui should be

@deagleSC
Copy link
Contributor

deagleSC commented Oct 2, 2021

@sahilsaif12 Dark mode looks good, consider doing the following:

  1. Keep the original file upload input field and the original vertical layout of the page.
  2. Make the rest of the color schemes and styles coherent with dscrcciit.com.
  3. I also recommend you start from a fresh clone, since there are UI glitches (Badge overflows out of screen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants