CI: Switch from LLVM 12 to 14 #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu-22.04 includes LLVM 14, but ubuntu-20.04 does not. As such, we cannot always install LLVM 14, but rather, we must choose which LLVM version to install based on which Ubuntu version we are using. While I am in town, this patch also factors out the LLVM version into a single `LINUX_LLVM_VER` environment variable and uses it everywhere so that we do not have to remember to update quite so many locations in the future. (I also do something similar with `MACOS_LLVM_VER`.)
langston-barrett
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation for doing so is to avoid using Homebrew's
llvm@12package, which appears to now be broken (#1255).Fixes #1255.