ML-DSA: Add rejection sampling functions #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marsella
force-pushed
the
188-sampling
branch
from
9b5a7f9 to
4144e8f
Compare
marsella
force-pushed
the
188-sampling
branch
from
4144e8f to
24b2f80
Compare
marsella
commented
Dec 11, 2024
Let's add it if it isn't to much of an ask. |
mccleeary-galois
approved these changes
Dec 11, 2024
|
Thank you! Added #207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
@mccleeary-galois: Do you want me to write properties for the function descriptions? E.g.
ExpandMasksays "Samples [...] coefficients between −𝛾1 + 1 and 𝛾1.". I currently don't have a property that checks the output of these sampling functions to make sure that the values are in range, but I can add it pretty easily.