Make validateConfiguration public to allow checking of validation query #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, jody. However, I thought the connection pool would normally validate the connection. Also, if a specific validation query is required, why give the user the option of setting it? Perhaps this should be a UI change? |
|
Yes, in this case I am wishing to provide form feedback from GeoServer incase they are missing a field. Presently GeoServer DiskQuota screen just saves the file, and it is not until GWC tries to read it that the result is validated. GeoServer does not try connecting before saving the changed file! |
… of validation query This method is used by GWC to check jdbc configuration files when loaded. Making the method public allows it to also be used by the GeoServer form.
jodygarnett
force-pushed
the
disk-quota-check-connection
branch
from
b2d8850 to
e05edc0
Compare
davidblasby
approved these changes
Oct 28, 2024
| cp.setDriver("org.postgresql.Driver"); | ||
| cp.setUrl("jdbc:postgresql:gttest"); | ||
|
|
||
| cp.setValidationQuery("select 1 from DUAL"); |
There was a problem hiding this comment.
I think dual is only for Oracle.
pgsql# select 1 from dual;
ERROR: relation "dual" does not exist
jodygarnett
added
backport 1.24.x
backport 1.25.x
backport 1.26.x
and removed
backport 1.24.x
backport 1.25.x
labels
|
The backport label is not success |
aaime
reviewed
Oct 29, 2024
| @@ -28,4 +29,7 @@ protected Properties createOfflineFixture() { | |||
| protected String getFixtureId() { | |||
| return "h2"; | |||
| } | |||
|
|
|||
| @Test | |||
| public void checkConnectionTest() {} | |||
There was a problem hiding this comment.
Don't think an empty test does much good... probably a leftover.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is used by GWC to check jdbc configuration files when loaded. Making the method public allows it to also be used by the GeoServer form.